[GH-ISSUE #671] Issue: Event type is not parsed from event file #431

New issue

Open

opened 2026-03-01 21:43:17 +03:00 by kerem · 4 comments

kerem commented 2026-03-01 21:43:17 +03:00

Owner

Copy link

Originally created by @catthehacker on GitHub (May 6, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/671

Originally assigned to: @catthehacker on GitHub.

Act version

github.com/nektos/act@8153dc92e5

Expected behaviour

event type should be parsed from event file

Actual behaviour

it defaults to push

Workflow and/or repository

n/a

Steps to reproduce

go run main.go -e pkg/runner/testdata/pull-request/event.json -W pkg/runner/testdata/pull-request/main.yaml -v

act output

Log

  ~/go/src/github.com/nektos/act cat/fix/event-json *4 ?1 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────  3s cat@alpine-vm 11:53:1
❯ act -e pkg/runner/testdata/pull-request/event.json -W pkg/runner/testdata/pull-request/main.yaml -v
DEBU[0000] Loading environment from /home/cat/go/src/github.com/nektos/act/.env 
DEBU[0000] Loading secrets from /home/cat/go/src/github.com/nektos/act/.secrets 
DEBU[0000] Loading workflow '/home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/main.yaml' 
DEBU[0000] Reading workflow '/home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/main.yaml' 
DEBU[0000] Planning event: push                         
DEBU[0000] Reading event.json from /home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/event.json 
  ~/go/src/github.com/nektos/act cat/fix/event-json *4 ?1 ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── cat@alpine-vm 12:02:5
❯

Originally created by @catthehacker on GitHub (May 6, 2021). Original GitHub issue: https://github.com/nektos/act/issues/671 Originally assigned to: @catthehacker on GitHub. <!-- - Make sure you are able to reproduce it on the [latest version](https://github.com/nektos/act/releases) - Search the existing issues. - Refer to [README](https://github.com/nektos/act/blob/master/README.md). --> ## Act version <!-- - Paste output of `act --version` inside the code block below - If you've built `act` yourself, please provide commit hash --> https://github.com/nektos/act/commit/8153dc92e5c34c51d02777b8274f05c399d3befc ## Expected behaviour event type should be parsed from event file ## Actual behaviour it defaults to push ## Workflow and/or repository n/a ## Steps to reproduce ```sh go run main.go -e pkg/runner/testdata/pull-request/event.json -W pkg/runner/testdata/pull-request/main.yaml -v ``` ## `act` output <!-- - Use `act` with `-v`/`--verbose` and paste output from your terminal in code block below --> <details> <summary>Log</summary> ```sh   ~/go/src/github.com/nektos/act cat/fix/event-json *4 ?1 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────  3s cat@alpine-vm 11:53:1 ❯ act -e pkg/runner/testdata/pull-request/event.json -W pkg/runner/testdata/pull-request/main.yaml -v DEBU[0000] Loading environment from /home/cat/go/src/github.com/nektos/act/.env DEBU[0000] Loading secrets from /home/cat/go/src/github.com/nektos/act/.secrets DEBU[0000] Loading workflow '/home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/main.yaml' DEBU[0000] Reading workflow '/home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/main.yaml' DEBU[0000] Planning event: push DEBU[0000] Reading event.json from /home/cat/go/src/github.com/nektos/act/pkg/runner/testdata/pull-request/event.json   ~/go/src/github.com/nektos/act cat/fix/event-json *4 ?1 ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── cat@alpine-vm 12:02:5 ❯ ``` </details>

kerem added the

kind/bug

stale-exempt

area/cli

labels 2026-03-01 21:43:17 +03:00

kerem commented 2026-03-01 21:43:18 +03:00

Author

Owner

Copy link

@catthehacker commented on GitHub (May 6, 2021):

This is some quick ugly fix that needs to be improved still. @cplee would you mind looking at this and give some opinion how (bad) that looks or what could be done better 😸

diff --git a/cmd/root.go b/cmd/root.go
index 13867b9..8d1a3a9 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -3,9 +3,13 @@ package cmd
 import (
        "bufio"
        "context"
+       "encoding/json"
+       "fmt"
+       "io/ioutil"
        "os"
        "path/filepath"
        "regexp"
+       "sort"
        "strings"
 
        "github.com/nektos/act/pkg/common"
@@ -176,8 +180,9 @@ func newRunCommand(ctx context.Context, input *Input) func(*cobra.Command, []str
                if input.autodetectEvent && len(events) > 0 {
                        // set default event type to first event
                        // this way user dont have to specify the event.
-                       log.Debugf("Using detected workflow event: %s", events[0])
                        eventName = events[0]
+               } else if input.eventPath != "" {
+                       eventName = parseEventFile(input.eventPath)
                } else {
                        if len(args) > 0 {
                                eventName = args[0]
@@ -185,6 +190,10 @@ func newRunCommand(ctx context.Context, input *Input) func(*cobra.Command, []str
                                eventName = "push"
                        }
                }
+               if res := sort.SearchStrings(model.Events, eventName); res == 0 {
+                       return fmt.Errorf("event type '%s' not found in a list of acceptable events", eventName)
+               }
+               log.Debugf("Using detected workflow event: %s", eventName)
 
                // build the plan for this run
                var plan *model.Plan
@@ -359,3 +368,144 @@ func watchAndRun(ctx context.Context, fn common.Executor) error {
        folderWatcher.Stop()
        return err
 }
+
+// parseEventFile returns proper event name based on content of event json file
+// nolint:gocyclo
+func parseEventFile(p string) string {
+       e := make(map[string]interface{})
+       eventJSONBytes, err := ioutil.ReadFile(p)
+       if err != nil {
+               log.Errorf("%v", err)
+               return ""
+       }
+
+       err = json.Unmarshal(eventJSONBytes, &e)
+       if err != nil {
+               log.Errorf("%v", err)
+               return ""
+       }
+
+       keys := make([]string, 0, len(e))
+       for k := range e {
+               keys = append(keys, k)
+       }
+       sort.Strings(keys)
+
+       // log.Debugf("json: %v", e)
+
+       if e["action"] == "revoked" {
+               return "github_app_authorization"
+       }
+       for _, k := range keys {
+               switch k {
+               case "check_run", "check_suite", "content_reference", "label", "marketplace_purchase", "milestone", "package",
+                       "project_card", "project_column", "project", "release", "security_advisory":
+                       return k
+               case "alert":
+                       if e["ref"] != nil {
+                               return "code_scanning_alert"
+                       }
+                       switch e["action"] {
+                       case "created", "resolved", "reopened":
+                               return "secret_scanning_alert"
+                       }
+                       return "repository_vulnerability_alert"
+               case "blocked_user":
+                       return "org_block"
+               case "comment":
+                       if e["pull_request"] == nil {
+                               if e["issue"] != nil {
+                                       return "issue_comment"
+                               }
+                               if e["discussion"] != nil {
+                                       return "discussion_comment"
+                               }
+                               return "commit_comment"
+                       }
+               case "client_payload":
+                       return "repository_dispatch"
+               case "deployment":
+                       if e["deployment_status"] != nil {
+                               return "deployment_status"
+                       }
+                       return "deployment"
+               case "member":
+                       if e["team"] != nil {
+                               return "membership"
+                       }
+                       return "member"
+               case "membership":
+                       return "organization"
+               case "ref":
+                       if e["ref_type"] != nil {
+                               if e["master_branch"] == nil {
+                                       return "delete"
+                               }
+                               return "create"
+                       }
+                       if e["workflow"] != nil {
+                               return "workflow_dispatch"
+                       }
+                       return "push"
+               case "key":
+                       return "deploy_key"
+               case "discussion":
+                       return k
+               case "forkee":
+                       return "fork"
+               case "pull_request":
+                       if e["comment"] != nil {
+                               return "pull_request_review_comment"
+                       }
+                       if e["review"] != nil {
+                               return "pull_request_review"
+                       }
+                       return k
+               case "pages":
+                       return "gollum"
+               case "hook_id":
+                       if e["zen"] != nil {
+                               return "ping"
+                       }
+                       return "meta"
+               case "issue":
+                       return "issues"
+               case "installation":
+                       if e["repository_selection"] != nil {
+                               return "installation_repositories"
+                       }
+                       return "installation"
+               case "build":
+                       return "page_build"
+               case "repository":
+                       if e["starred_at"] != nil {
+                               return "star"
+                       }
+                       if e["team"] != nil {
+                               if e["action"] != nil {
+                                       return "team"
+                               }
+                               return "team_add"
+                       }
+                       if e["state"] != nil {
+                               return "status"
+                       }
+                       if e["action"] != nil {
+                               if e["action"] == "started" {
+                                       return "watch"
+                               }
+                               if e["action"] == "requested" || e["action"] == "completed" {
+                                       return "workflow_run"
+                               }
+                               return "repository"
+                       }
+                       if e["status"] != nil {
+                               return "repository_import"
+                       }
+                       return "public"
+               case "sponsorship":
+                       return "sponsorship"
+               }
+       }
+       return ""
+}
diff --git a/cmd/root_test.go b/cmd/root_test.go
new file mode 100644
index 0000000..356dbfb
--- /dev/null
+++ b/cmd/root_test.go
@@ -0,0 +1,35 @@
+package cmd
+
+import (
+       "errors"
+       "io/ioutil"
+       "os"
+       "path/filepath"
+       "strings"
+       "testing"
+
+       "github.com/nektos/act/pkg/model"
+       log "github.com/sirupsen/logrus"
+       "gotest.tools/v3/assert"
+)
+
+func TestParseEventFile(t *testing.T) {
+       log.SetLevel(log.DebugLevel)
+       for _, event := range model.Events {
+               p := filepath.Join("..", "pkg", "runner", "testdata", "event-types", strings.ReplaceAll(event, `_`, `-`))
+               log.Debugf("Path: %s", p)
+
+               _, err := os.Lstat(p)
+               if errors.Is(err, os.ErrNotExist) {
+                       err = os.MkdirAll(p, 0766)
+                       assert.NilError(t, err, "")
+
+                       err = ioutil.WriteFile(filepath.Join(p, "event.json"), []byte{}, 0600)
+                       assert.NilError(t, err, "")
+               } else {
+                       eventName := parseEventFile(filepath.Join(p, "event.json"))
+                       log.Debugf("event: %s, eventName: %s", event, eventName)
+                       assert.Equal(t, eventName, event)
+               }
+       }
+}
diff --git a/pkg/model/planner.go b/pkg/model/planner.go
index 3c2a660..42b5f57 100644
--- a/pkg/model/planner.go
+++ b/pkg/model/planner.go
@@ -14,6 +14,17 @@ import (
        log "github.com/sirupsen/logrus"
 )
 
+// Events contains all allowed event names
+var Events = []string{
+       "check_run", "check_suite", "code_scanning_alert", "commit_comment", "content_reference", "create", "delete", "deploy_key",
+       "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "github_app_authorization", "gollum", "installation",
+       "installation_repositories", "issue_comment", "issues", "label", "marketplace_purchase", "member", "membership", "meta", "milestone",
+       "organization", "org_block", "package", "page_build", "ping", "project_card", "project_column", "project", "public", "pull_request",
+       "pull_request_review", "pull_request_review_comment", "push", "release", "repository_dispatch", "repository", "repository_import",
+       "repository_vulnerability_alert", "secret_scanning_alert", "security_advisory", "sponsorship", "star", "status", "team", "team_add",
+       "watch", "workflow_dispatch", "workflow_run",
+}
+
 // WorkflowPlanner contains methods for creating plans
 type WorkflowPlanner interface {
        PlanEvent(eventName string) *Plan
diff --git a/pkg/runner/run_context.go b/pkg/runner/run_context.go
index 612f473..bfa2e6c 100755
--- a/pkg/runner/run_context.go
+++ b/pkg/runner/run_context.go
@@ -524,32 +524,33 @@ func (rc *RunContext) getGithubContext() *githubContext {
                }
        }
 
-       maybeRef := nestedMapLookup(ghc.Event, ghc.EventName, "ref")
-       if maybeRef != nil {
-               log.Debugf("using github ref from event: %s", maybeRef)
-               ghc.Ref = maybeRef.(string)
-       } else {
-               ref, err := common.FindGitRef(repoPath)
-               if err != nil {
-                       log.Warningf("unable to get git ref: %v", err)
+       switch ghc.EventName {
+       case "pull_request":
+               ghc.BaseRef = asString(nestedMapLookup(ghc.Event, "pull_request", "base", "ref"))
+               ghc.HeadRef = asString(nestedMapLookup(ghc.Event, "pull_request", "head", "ref"))
+       default:
+               maybeRef := nestedMapLookup(ghc.Event, ghc.EventName, "ref")
+               if maybeRef != nil {
+                       log.Debugf("using github ref from event: %s", maybeRef)
+                       ghc.Ref = maybeRef.(string)
                } else {
-                       log.Debugf("using github ref: %s", ref)
-                       ghc.Ref = ref
-               }
+                       ref, err := common.FindGitRef(repoPath)
+                       if err != nil {
+                               log.Warningf("unable to get git ref: %v", err)
+                       } else {
+                               log.Debugf("using github ref: %s", ref)
+                               ghc.Ref = ref
+                       }
 
-               // set the branch in the event data
-               if rc.Config.DefaultBranch != "" {
-                       ghc.Event = withDefaultBranch(rc.Config.DefaultBranch, ghc.Event)
-               } else {
-                       ghc.Event = withDefaultBranch("master", ghc.Event)
+                       // set the branch in the event data
+                       if rc.Config.DefaultBranch != "" {
+                               ghc.Event = withDefaultBranch(rc.Config.DefaultBranch, ghc.Event)
+                       } else {
+                               ghc.Event = withDefaultBranch("master", ghc.Event)
+                       }
                }
        }
 
-       if ghc.EventName == "pull_request" {
-               ghc.BaseRef = asString(nestedMapLookup(ghc.Event, "pull_request", "base", "ref"))
-               ghc.HeadRef = asString(nestedMapLookup(ghc.Event, "pull_request", "head", "ref"))
-       }
-
        return ghc
 }
 
diff --git a/pkg/runner/runner.go b/pkg/runner/runner.go
index 9262b96..7a49031 100644
--- a/pkg/runner/runner.go
+++ b/pkg/runner/runner.go
@@ -100,6 +100,7 @@ func New(runnerConfig *Config) (Runner, error) {
                        return nil, err
                }
                runner.eventJSON = string(eventJSONBytes)
+               log.Debugf("Event JSON: '%s'", runner.eventJSON)
        }
        return runner, nil
 }
diff --git a/pkg/runner/runner_test.go b/pkg/runner/runner_test.go
index 89e1061..304bafd 100644
--- a/pkg/runner/runner_test.go
+++ b/pkg/runner/runner_test.go
@@ -173,32 +173,34 @@ func TestRunEventPullRequest(t *testing.T) {
        ctx := context.Background()
 
        platforms := map[string]string{
-               "ubuntu-latest": "node:12.20.1-buster-slim",
+               "ubuntu-latest": "node:12.20-buster-slim",
        }
 
-       workflowPath := "pull-request"
-       eventName := "pull_request"
+       for _, event := range model.Events {
+               workflowPath := strings.ReplaceAll(event, `_`, `-`)
+               eventName := event
 
-       workdir, err := filepath.Abs("testdata")
-       assert.NilError(t, err, workflowPath)
+               workdir, err := filepath.Abs("testdata")
+               assert.NilError(t, err, workflowPath)
 
-       runnerConfig := &Config{
-               Workdir:         workdir,
-               EventName:       eventName,
-               EventPath:       filepath.Join(workdir, workflowPath, "event.json"),
-               Platforms:       platforms,
-               ReuseContainers: false,
-       }
-       runner, err := New(runnerConfig)
-       assert.NilError(t, err, workflowPath)
+               runnerConfig := &Config{
+                       Workdir:         workdir,
+                       EventName:       eventName,
+                       EventPath:       filepath.Join(workdir, workflowPath, "event.json"),
+                       Platforms:       platforms,
+                       ReuseContainers: false,
+               }
+               runner, err := New(runnerConfig)
+               assert.NilError(t, err, workflowPath)
 
-       planner, err := model.NewWorkflowPlanner(fmt.Sprintf("testdata/%s", workflowPath), true)
-       assert.NilError(t, err, workflowPath)
+               planner, err := model.NewWorkflowPlanner(filepath.Join("testdata", "event-types", workflowPath), true)
+               assert.NilError(t, err, workflowPath)
 
-       plan := planner.PlanEvent(eventName)
+               plan := planner.PlanEvent(eventName)
 
-       err = runner.NewPlanExecutor(plan)(ctx)
-       assert.NilError(t, err, workflowPath)
+               err = runner.NewPlanExecutor(plan)(ctx)
+               assert.NilError(t, err, workflowPath)
+       }
 }
 
 func TestContainerPath(t *testing.T) {

branch: https://github.com/catthehacker/act-fork/tree/cat/fix%2Fevent-json

<!-- gh-comment-id:833480224 --> @catthehacker commented on GitHub (May 6, 2021): This is some quick ugly fix that needs to be improved still. @cplee would you mind looking at this and give some opinion how (bad) that looks or what could be done better 😸 ```diff diff --git a/cmd/root.go b/cmd/root.go index 13867b9..8d1a3a9 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -3,9 +3,13 @@ package cmd import ( "bufio" "context" + "encoding/json" + "fmt" + "io/ioutil" "os" "path/filepath" "regexp" + "sort" "strings" "github.com/nektos/act/pkg/common" @@ -176,8 +180,9 @@ func newRunCommand(ctx context.Context, input *Input) func(*cobra.Command, []str if input.autodetectEvent && len(events) > 0 { // set default event type to first event // this way user dont have to specify the event. - log.Debugf("Using detected workflow event: %s", events[0]) eventName = events[0] + } else if input.eventPath != "" { + eventName = parseEventFile(input.eventPath) } else { if len(args) > 0 { eventName = args[0] @@ -185,6 +190,10 @@ func newRunCommand(ctx context.Context, input *Input) func(*cobra.Command, []str eventName = "push" } } + if res := sort.SearchStrings(model.Events, eventName); res == 0 { + return fmt.Errorf("event type '%s' not found in a list of acceptable events", eventName) + } + log.Debugf("Using detected workflow event: %s", eventName) // build the plan for this run var plan *model.Plan @@ -359,3 +368,144 @@ func watchAndRun(ctx context.Context, fn common.Executor) error { folderWatcher.Stop() return err } + +// parseEventFile returns proper event name based on content of event json file +// nolint:gocyclo +func parseEventFile(p string) string { + e := make(map[string]interface{}) + eventJSONBytes, err := ioutil.ReadFile(p) + if err != nil { + log.Errorf("%v", err) + return "" + } + + err = json.Unmarshal(eventJSONBytes, &e) + if err != nil { + log.Errorf("%v", err) + return "" + } + + keys := make([]string, 0, len(e)) + for k := range e { + keys = append(keys, k) + } + sort.Strings(keys) + + // log.Debugf("json: %v", e) + + if e["action"] == "revoked" { + return "github_app_authorization" + } + for _, k := range keys { + switch k { + case "check_run", "check_suite", "content_reference", "label", "marketplace_purchase", "milestone", "package", + "project_card", "project_column", "project", "release", "security_advisory": + return k + case "alert": + if e["ref"] != nil { + return "code_scanning_alert" + } + switch e["action"] { + case "created", "resolved", "reopened": + return "secret_scanning_alert" + } + return "repository_vulnerability_alert" + case "blocked_user": + return "org_block" + case "comment": + if e["pull_request"] == nil { + if e["issue"] != nil { + return "issue_comment" + } + if e["discussion"] != nil { + return "discussion_comment" + } + return "commit_comment" + } + case "client_payload": + return "repository_dispatch" + case "deployment": + if e["deployment_status"] != nil { + return "deployment_status" + } + return "deployment" + case "member": + if e["team"] != nil { + return "membership" + } + return "member" + case "membership": + return "organization" + case "ref": + if e["ref_type"] != nil { + if e["master_branch"] == nil { + return "delete" + } + return "create" + } + if e["workflow"] != nil { + return "workflow_dispatch" + } + return "push" + case "key": + return "deploy_key" + case "discussion": + return k + case "forkee": + return "fork" + case "pull_request": + if e["comment"] != nil { + return "pull_request_review_comment" + } + if e["review"] != nil { + return "pull_request_review" + } + return k + case "pages": + return "gollum" + case "hook_id": + if e["zen"] != nil { + return "ping" + } + return "meta" + case "issue": + return "issues" + case "installation": + if e["repository_selection"] != nil { + return "installation_repositories" + } + return "installation" + case "build": + return "page_build" + case "repository": + if e["starred_at"] != nil { + return "star" + } + if e["team"] != nil { + if e["action"] != nil { + return "team" + } + return "team_add" + } + if e["state"] != nil { + return "status" + } + if e["action"] != nil { + if e["action"] == "started" { + return "watch" + } + if e["action"] == "requested" || e["action"] == "completed" { + return "workflow_run" + } + return "repository" + } + if e["status"] != nil { + return "repository_import" + } + return "public" + case "sponsorship": + return "sponsorship" + } + } + return "" +} diff --git a/cmd/root_test.go b/cmd/root_test.go new file mode 100644 index 0000000..356dbfb --- /dev/null +++ b/cmd/root_test.go @@ -0,0 +1,35 @@ +package cmd + +import ( + "errors" + "io/ioutil" + "os" + "path/filepath" + "strings" + "testing" + + "github.com/nektos/act/pkg/model" + log "github.com/sirupsen/logrus" + "gotest.tools/v3/assert" +) + +func TestParseEventFile(t *testing.T) { + log.SetLevel(log.DebugLevel) + for _, event := range model.Events { + p := filepath.Join("..", "pkg", "runner", "testdata", "event-types", strings.ReplaceAll(event, `_`, `-`)) + log.Debugf("Path: %s", p) + + _, err := os.Lstat(p) + if errors.Is(err, os.ErrNotExist) { + err = os.MkdirAll(p, 0766) + assert.NilError(t, err, "") + + err = ioutil.WriteFile(filepath.Join(p, "event.json"), []byte{}, 0600) + assert.NilError(t, err, "") + } else { + eventName := parseEventFile(filepath.Join(p, "event.json")) + log.Debugf("event: %s, eventName: %s", event, eventName) + assert.Equal(t, eventName, event) + } + } +} diff --git a/pkg/model/planner.go b/pkg/model/planner.go index 3c2a660..42b5f57 100644 --- a/pkg/model/planner.go +++ b/pkg/model/planner.go @@ -14,6 +14,17 @@ import ( log "github.com/sirupsen/logrus" ) +// Events contains all allowed event names +var Events = []string{ + "check_run", "check_suite", "code_scanning_alert", "commit_comment", "content_reference", "create", "delete", "deploy_key", + "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "github_app_authorization", "gollum", "installation", + "installation_repositories", "issue_comment", "issues", "label", "marketplace_purchase", "member", "membership", "meta", "milestone", + "organization", "org_block", "package", "page_build", "ping", "project_card", "project_column", "project", "public", "pull_request", + "pull_request_review", "pull_request_review_comment", "push", "release", "repository_dispatch", "repository", "repository_import", + "repository_vulnerability_alert", "secret_scanning_alert", "security_advisory", "sponsorship", "star", "status", "team", "team_add", + "watch", "workflow_dispatch", "workflow_run", +} + // WorkflowPlanner contains methods for creating plans type WorkflowPlanner interface { PlanEvent(eventName string) *Plan diff --git a/pkg/runner/run_context.go b/pkg/runner/run_context.go index 612f473..bfa2e6c 100755 --- a/pkg/runner/run_context.go +++ b/pkg/runner/run_context.go @@ -524,32 +524,33 @@ func (rc *RunContext) getGithubContext() *githubContext { } } - maybeRef := nestedMapLookup(ghc.Event, ghc.EventName, "ref") - if maybeRef != nil { - log.Debugf("using github ref from event: %s", maybeRef) - ghc.Ref = maybeRef.(string) - } else { - ref, err := common.FindGitRef(repoPath) - if err != nil { - log.Warningf("unable to get git ref: %v", err) + switch ghc.EventName { + case "pull_request": + ghc.BaseRef = asString(nestedMapLookup(ghc.Event, "pull_request", "base", "ref")) + ghc.HeadRef = asString(nestedMapLookup(ghc.Event, "pull_request", "head", "ref")) + default: + maybeRef := nestedMapLookup(ghc.Event, ghc.EventName, "ref") + if maybeRef != nil { + log.Debugf("using github ref from event: %s", maybeRef) + ghc.Ref = maybeRef.(string) } else { - log.Debugf("using github ref: %s", ref) - ghc.Ref = ref - } + ref, err := common.FindGitRef(repoPath) + if err != nil { + log.Warningf("unable to get git ref: %v", err) + } else { + log.Debugf("using github ref: %s", ref) + ghc.Ref = ref + } - // set the branch in the event data - if rc.Config.DefaultBranch != "" { - ghc.Event = withDefaultBranch(rc.Config.DefaultBranch, ghc.Event) - } else { - ghc.Event = withDefaultBranch("master", ghc.Event) + // set the branch in the event data + if rc.Config.DefaultBranch != "" { + ghc.Event = withDefaultBranch(rc.Config.DefaultBranch, ghc.Event) + } else { + ghc.Event = withDefaultBranch("master", ghc.Event) + } } } - if ghc.EventName == "pull_request" { - ghc.BaseRef = asString(nestedMapLookup(ghc.Event, "pull_request", "base", "ref")) - ghc.HeadRef = asString(nestedMapLookup(ghc.Event, "pull_request", "head", "ref")) - } - return ghc } diff --git a/pkg/runner/runner.go b/pkg/runner/runner.go index 9262b96..7a49031 100644 --- a/pkg/runner/runner.go +++ b/pkg/runner/runner.go @@ -100,6 +100,7 @@ func New(runnerConfig *Config) (Runner, error) { return nil, err } runner.eventJSON = string(eventJSONBytes) + log.Debugf("Event JSON: '%s'", runner.eventJSON) } return runner, nil } diff --git a/pkg/runner/runner_test.go b/pkg/runner/runner_test.go index 89e1061..304bafd 100644 --- a/pkg/runner/runner_test.go +++ b/pkg/runner/runner_test.go @@ -173,32 +173,34 @@ func TestRunEventPullRequest(t *testing.T) { ctx := context.Background() platforms := map[string]string{ - "ubuntu-latest": "node:12.20.1-buster-slim", + "ubuntu-latest": "node:12.20-buster-slim", } - workflowPath := "pull-request" - eventName := "pull_request" + for _, event := range model.Events { + workflowPath := strings.ReplaceAll(event, `_`, `-`) + eventName := event - workdir, err := filepath.Abs("testdata") - assert.NilError(t, err, workflowPath) + workdir, err := filepath.Abs("testdata") + assert.NilError(t, err, workflowPath) - runnerConfig := &Config{ - Workdir: workdir, - EventName: eventName, - EventPath: filepath.Join(workdir, workflowPath, "event.json"), - Platforms: platforms, - ReuseContainers: false, - } - runner, err := New(runnerConfig) - assert.NilError(t, err, workflowPath) + runnerConfig := &Config{ + Workdir: workdir, + EventName: eventName, + EventPath: filepath.Join(workdir, workflowPath, "event.json"), + Platforms: platforms, + ReuseContainers: false, + } + runner, err := New(runnerConfig) + assert.NilError(t, err, workflowPath) - planner, err := model.NewWorkflowPlanner(fmt.Sprintf("testdata/%s", workflowPath), true) - assert.NilError(t, err, workflowPath) + planner, err := model.NewWorkflowPlanner(filepath.Join("testdata", "event-types", workflowPath), true) + assert.NilError(t, err, workflowPath) - plan := planner.PlanEvent(eventName) + plan := planner.PlanEvent(eventName) - err = runner.NewPlanExecutor(plan)(ctx) - assert.NilError(t, err, workflowPath) + err = runner.NewPlanExecutor(plan)(ctx) + assert.NilError(t, err, workflowPath) + } } func TestContainerPath(t *testing.T) { ``` branch: https://github.com/catthehacker/act-fork/tree/cat/fix%2Fevent-json

kerem commented 2026-03-01 21:43:18 +03:00

Author

Owner

Copy link

@github-actions[bot] commented on GitHub (Jun 11, 2021):

Issue is stale and will be closed in 14 days unless there is new activity

<!-- gh-comment-id:859166320 --> @github-actions[bot] commented on GitHub (Jun 11, 2021): Issue is stale and will be closed in 14 days unless there is new activity

kerem commented 2026-03-01 21:43:18 +03:00

Author

Owner

Copy link

@dimaqq commented on GitHub (Jan 27, 2023):

Might this also be fixed by #1428?

<!-- gh-comment-id:1406000786 --> @dimaqq commented on GitHub (Jan 27, 2023): Might this also be fixed by #1428?

kerem commented 2026-03-01 21:43:18 +03:00

Author

Owner

Copy link

@Dr-Electron commented on GitHub (Aug 10, 2024):

Not sure it is.

I have this simple workflow-test.yml:

on:  
  pull_request:
    types: [ready_for_review]

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - name: Test
        run: echo test

and the following event.json:

{
    "action": "opened",
    "pull_request": {
        "head": {
            "ref": "sample-head-ref"
        },
        "base": {
            "ref": "main"
        }
    }
}

And if I run:

act pull_request -W ./.github/workflows/workflow-testyml -e event.json

it runs, although it shouldn't as the type is opened not ready_for_review

<!-- gh-comment-id:2282261693 --> @Dr-Electron commented on GitHub (Aug 10, 2024): Not sure it is. I have this simple workflow-test.yml: ```yaml on: pull_request: types: [ready_for_review] jobs: test: runs-on: ubuntu-latest steps: - name: Test run: echo test ``` and the following `event.json`: ```json { "action": "opened", "pull_request": { "head": { "ref": "sample-head-ref" }, "base": { "ref": "main" } } } ``` And if I run: ``` act pull_request -W ./.github/workflows/workflow-testyml -e event.json ``` it runs, although it shouldn't as the type is `opened` not `ready_for_review`

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

dependabot/go_modules/github.com/go-git/go-git/v5-5.18.0

dependabot/go_modules/dependencies-08815e2262

mergify/configuration-deprecated-update

dependabot/github_actions/dependencies-a3a104477f

chore/simplify-ci-and-makefile

dependabot/go_modules/golang.org/x/crypto-0.45.0

dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0

panekj/ci/improve-jobs

fix-skip-non-yaml-files-in-dir

normalize-pull-rebuild-flags

fix-no-recurse-by-default

2517-poor-error-for-incomplete-action-step

2472-make-use-new-action-cache-the-new-default-for-downloading-actions

act-tart

act-lxc

act-oidc

act-dind

avoid-slash-in-actor

dependabot/go_modules/github.com/docker/docker-26.1.4incompatible

meta-keep-filetime

local-repository-action-cache

pr-merger

update-docker-deps

follow_local_action_symlink

boltdb-lock-in-handler

use-socket-path

no-pull-no-rebuild

path-issues

fix/env

feat/podman

refactor/testdata

v0.2.87

v0.2.86

v0.2.85

v0.2.84

v0.2.83

v0.2.82

v0.2.81

v0.2.80

v0.2.79

v0.2.78

v0.2.77

v0.2.76

v0.2.75

v0.2.74

v0.2.73

v0.2.72

v0.2.71

v0.2.70

v0.2.69

v0.2.68

v0.2.67

v0.2.66

v0.2.65

v0.2.64

v0.2.63

v0.2.62

v0.2.61

v0.2.60

v0.2.59

v0.2.58

v0.2.57

v0.2.56

v0.2.55

v0.2.54

v0.2.53

v0.2.52

v0.2.51

v0.2.50

v0.2.49

v0.2.48

v0.2.47

v0.2.46

v0.2.45

v0.2.44

v0.2.43

v0.2.42

v0.2.41

v0.2.40

v0.2.39

v0.2.38

v0.2.37

v0.2.36

v0.2.35

v0.2.34

v0.2.33

v0.2.32

v0.2.31

v0.2.30

v0.2.29

v0.2.28

v0.2.27

v0.2.26

v0.2.25

v0.2.24

v0.2.23

v0.2.22

v0.2.21

v0.2.20

v0.2.19

v0.2.18

v0.2.17

v0.2.16

v0.2.15

v0.2.14

v0.2.13

v0.2.12

v0.2.11

v0.2.10

v0.2.9

v0.2.8

v0.2.7

v0.2.6

v0.2.5

v0.2.4

v0.2.3

v0.2.2

v0.2.1

v0.2.0

v0.1.3

v0.1.2

v0.1.1

v0.1.0

v0.0.5

v0.0.4

v0.0.3

v0.0.2

v0.0.1

Labels

Clear labels   

area/action

  

area/cli

  

area/docs

  

area/image

  

area/runner

  

area/workflow

  

backlog

  

confirmed/not-planned

  

kind/bug

  

kind/discussion

  

kind/external

  

kind/feature-request

  

kind/question

  

meta/duplicate

  

meta/invalid

  

meta/need-more-info

  

meta/resolved

  

meta/wontfix

  

meta/workaround

  

needs-work

  

pull-request

Mirrored from GitHub Pull Request

  

review/not-planned

  

size/M

  

size/XL

  

size/XXL

  

stale

  

stale-exempt

No labels

area/action

area/cli

area/docs

area/image

area/runner

area/workflow

backlog

confirmed/not-planned

kind/bug

kind/discussion

kind/external

kind/feature-request

kind/question

meta/duplicate

meta/invalid

meta/need-more-info

meta/resolved

meta/wontfix

meta/workaround

needs-work

pull-request

review/not-planned

size/M

size/XL

size/XXL

stale

stale-exempt

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#431

No description provided.