mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #656] Issue: act doesn't remove images properly when switching container architecture #428
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#428
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jsoref on GitHub (May 4, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/656
Originally assigned to: @catthehacker on GitHub.
Act version
Expected behaviour
unless
--container-architectureis specified, the architecture used by a run ofactshould be the host architecture (in my case, amd64)Actual behaviour
The architecture used by
actis the--container-architecturefrom the last timeactwas run with--container-architectureWorkflow and/or repository
workflow
Steps to reproduce
actoutputLog
@catthehacker commented on GitHub (May 4, 2021):
it's the current
actbehaviour@catthehacker commented on GitHub (May 4, 2021):
The only thing that might not be working properly is finding/removing image to use, since one tag cannot point to 2 different docker images it's doing hacky thing to remove all invalid architectures and load proper one
@jsoref commented on GitHub (May 4, 2021):
Sounds like by removing the images, it's leaving only the last used image architecture available, and the next time it does the removes it restores the one for the requested architecture.
@catthehacker commented on GitHub (May 4, 2021):
well, since
actdoesn't specify which architecture to use and it doesn't know which to run, it doesn't remove the image which is incorrect, so if there is one with incorrect platform it will run itgithub.com/nektos/act@f32babb51d/pkg/container/docker_images.go (L31-L34)@catthehacker commented on GitHub (May 5, 2021):
mhm, weird thing
for some reason linter really wants to run in
linux/arm64🤔@github-actions[bot] commented on GitHub (Jun 6, 2021):
Issue is stale and will be closed in 14 days unless there is new activity