starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00

[GH-ISSUE #644] [Build] Should the test* Github Action workflows changed to workflow_dispatch? #422

New issue

Closed

opened 2026-03-01 21:43:13 +03:00 by kerem · 6 comments

kerem commented

2026-03-01 21:43:13 +03:00

Owner

Originally created by @JustinGrote on GitHub (Apr 28, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/644

I keep seeing these test workflows run on all actions but they appear to have been experiments rather than any kind of testing or gatekeeping check. Should they be switched to manual triggers so they aren't running all the time or is there a benefit I'm not seeing here?

Originally created by @JustinGrote on GitHub (Apr 28, 2021). Original GitHub issue: https://github.com/nektos/act/issues/644 I keep seeing these test workflows run on all actions but they appear to have been experiments rather than any kind of testing or gatekeeping check. Should they be switched to manual triggers so they aren't running all the time or is there a benefit I'm not seeing here? ![image](https://user-images.githubusercontent.com/15258962/116451993-0e6f8780-a812-11eb-9ccb-d80e08118700.png)

kerem

2026-03-01 21:43:13 +03:00

closed this issue
added the
kind/question
label

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@catthehacker commented on GitHub (Apr 28, 2021):

Nope, they should be running all the time. Those are generated by tests and are verifying behaviour between act and GitHub Actions:

test-if.yml in run_context_test.go
test-expressions.yml in expression_test.go
test-composite.yml was added due to misunderstanding but it does no harm

@catthehacker commented on GitHub (Apr 28, 2021): Nope, they should be running all the time. Those are generated by tests and are verifying behaviour between `act` and GitHub Actions: - `test-if.yml` in `run_context_test.go` - `test-expressions.yml` in `expression_test.go` - `test-composite.yml` was added due to [misunderstanding](https://github.com/nektos/act/pull/514#pullrequestreview-622854385) but it does no harm

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@JustinGrote commented on GitHub (Apr 28, 2021):

Apparently i only spot checked test-composite. All good!

@JustinGrote commented on GitHub (Apr 28, 2021): Apparently i only spot checked test-composite. All good!

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@JustinGrote commented on GitHub (Apr 28, 2021):

@catthehacker sorry, I reviewed the test and I don't see where it's actually being verified, it just writes out the test

And the resulting workflow isn't in the list of checks for PRs. Are you manually reviewing them or what am I missing?

@JustinGrote commented on GitHub (Apr 28, 2021): @catthehacker sorry, I reviewed the test and I don't see where it's actually being verified, it just writes out the test ![image](https://user-images.githubusercontent.com/15258962/116453676-044e8880-a814-11eb-8801-9312f16d9e3f.png) And the resulting workflow isn't in the list of checks for PRs. Are you manually reviewing them or what am I missing? ![image](https://user-images.githubusercontent.com/15258962/116453925-4677ca00-a814-11eb-9bfc-de57bae481c3.png)

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@catthehacker commented on GitHub (Apr 28, 2021):

if you run act in act/ it will verify it ;)
Serious answer: Verifying in terms, we can see how GitHub handles those expressions

@catthehacker commented on GitHub (Apr 28, 2021): if you run `act` in `act/` it will verify it ;) Serious answer: Verifying in terms, we can see how GitHub handles those expressions

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@JustinGrote commented on GitHub (Apr 28, 2021):

Fair...

@JustinGrote commented on GitHub (Apr 28, 2021): Fair...

kerem commented

2026-03-01 21:43:14 +03:00

Author

Owner

@catthehacker commented on GitHub (Apr 28, 2021):

@catthehacker sorry, I reviewed the test and I don't see where it's actually being verified, it just writes out the test

And the resulting workflow isn't in the list of checks for PRs. Are you manually reviewing them or what am I missing?

@JustinGrote

Actually, no, I thought good that we tested them both in act and GHA. Sorry, it's already late and my brain is switching off slowly after work 😄
github.com/nektos/act@f56b21f6c3/pkg/runner/expression_test.go (L187-L195)

github.com/nektos/act@f56b21f6c3/pkg/runner/run_context_test.go (L138-L152)

@catthehacker commented on GitHub (Apr 28, 2021): > @catthehacker sorry, I reviewed the test and I don't see where it's actually being verified, it just writes out the test > ![image](https://user-images.githubusercontent.com/15258962/116453676-044e8880-a814-11eb-8801-9312f16d9e3f.png) > > And the resulting workflow isn't in the list of checks for PRs. Are you manually reviewing them or what am I missing? > ![image](https://user-images.githubusercontent.com/15258962/116453925-4677ca00-a814-11eb-9bfc-de57bae481c3.png) @JustinGrote Actually, no, I thought good that we tested them both in `act` and GHA. Sorry, it's already late and my brain is switching off slowly after work 😄 https://github.com/nektos/act/blob/f56b21f6c3549b347413d338dfdd0d238eb534b6/pkg/runner/expression_test.go#L187-L195 https://github.com/nektos/act/blob/f56b21f6c3549b347413d338dfdd0d238eb534b6/pkg/runner/run_context_test.go#L138-L152

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#422

No description provided.

Rows
Columns