[GH-ISSUE #527] Enhancement: Authentication to docker registry #357

Closed
opened 2026-03-01 21:42:37 +03:00 by kerem · 2 comments
Owner

Originally created by @KnisterPeter on GitHub (Feb 10, 2021).
Original GitHub issue: https://github.com/nektos/act/issues/527

Describe feature

It would be nice to create an authenticated docker api client to pull images from other registries which require authentication.
I think it might be good enough to add the authentication information found in ~/.docker/config.json into the pull command.

github.com/nektos/act@e6fcfed458/pkg/container/docker_pull.go (L55)

The ImagePullOptions seems to allow this:
github.com/moby/moby@46cdcd206c/api/types/client.go (L253-L258)

Originally created by @KnisterPeter on GitHub (Feb 10, 2021). Original GitHub issue: https://github.com/nektos/act/issues/527 ## Describe feature It would be nice to create an authenticated docker api client to pull images from other registries which require authentication. I think it might be good enough to add the authentication information found in `~/.docker/config.json` into the pull command. https://github.com/nektos/act/blob/e6fcfed458dbccd640e093bffd0fc258d6ce0e6e/pkg/container/docker_pull.go#L55 The `ImagePullOptions` seems to allow this: https://github.com/moby/moby/blob/46cdcd206c56172b95ba5c77b827a722dab426c5/api/types/client.go#L253-L258
Author
Owner

@github-actions[bot] commented on GitHub (Mar 13, 2021):

Issue is stale and will be closed in 14 days unless there is new activity

<!-- gh-comment-id:797829614 --> @github-actions[bot] commented on GitHub (Mar 13, 2021): Issue is stale and will be closed in 14 days unless there is new activity
Author
Owner

@catthehacker commented on GitHub (Mar 13, 2021):

Not stale, will make PR for that today/tomorrow feel free to grab that, I'm currently unable to implement that.

<!-- gh-comment-id:798350179 --> @catthehacker commented on GitHub (Mar 13, 2021): Not stale, ~~will make PR for that today/tomorrow~~ feel free to grab that, I'm currently unable to implement that.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#357
No description provided.