[PR #5994] feat: split platform arg by the last = #2651

New issue

Open

opened 2026-03-01 22:37:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 22:37:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/5994
Author: @samuelhnrq
Created: 1/15/2026
Status: 🔄 Open

Base: master ← Head: parse-platform-equal

📝 Commits (3)

e3487f3 fix: split platform arg by the last =
a5910e8 fix: do not consider strings starting with =
c802ad7 feat: add platform multi = tests

📊 Changes

2 files changed (+52 additions, -3 deletions)

View changed files

📝 cmd/platforms.go (+12 -3)
➕ cmd/platforms_test.go (+40 -0)

📄 Description

Changes the parsing of the -P/--platform flag to consider the last = instead of the first.

Point being = is a valid character for a runs-on definition but it's not for docker images. Splitting the -P flag at the last = should be a good enough heuristic to support equal character while still being backward compatible.

Fixes #4691

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/5994 **Author:** [@samuelhnrq](https://github.com/samuelhnrq) **Created:** 1/15/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `parse-platform-equal` --- ### 📝 Commits (3) - [`e3487f3`](https://github.com/nektos/act/commit/e3487f3af35b7ebdef07e6c8dd22c17202eaf785) fix: split platform arg by the last = - [`a5910e8`](https://github.com/nektos/act/commit/a5910e83d13c4ef996ef0e2c441f87187ddae4bb) fix: do not consider strings starting with = - [`c802ad7`](https://github.com/nektos/act/commit/c802ad7e25f2999fcb6e56591054a6c53340e1c6) feat: add platform multi = tests ### 📊 Changes **2 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/platforms.go` (+12 -3) ➕ `cmd/platforms_test.go` (+40 -0) </details> ### 📄 Description Changes the parsing of the -P/--platform flag to consider the last = instead of the first. Point being `=` is a valid character for a runs-on definition but it's not for docker images. Splitting the -P flag at the last `=` should be a good enough heuristic to support equal character while still being backward compatible. Fixes #4691 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-01 22:37:35 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2651

No description provided.

Rows
Columns