[PR #5973] fix possible leakage of secrets in debug logging #2641

Open
opened 2026-03-01 22:37:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/5973
Author: @drornir
Created: 11/22/2025
Status: 🔄 Open

Base: masterHead: drornir


📝 Commits (2)

  • 41f4036 fix possible leakage of secrets in debug logging
  • dc6d4d5 fixed %t to masked %s

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 pkg/runner/expression.go (+6 -4)

📄 Description

Found this while browsing the source code.

I just thought it was odd to to a regex replace on the string 'true' or 'false' so it caught my attention.

I know it's not an important fix but I was here so why not.

reference to the commit that originally changed this:
github.com/nektos/act@4391a10d5a (diff-4fe45e900e)
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/5973 **Author:** [@drornir](https://github.com/drornir) **Created:** 11/22/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `drornir` --- ### 📝 Commits (2) - [`41f4036`](https://github.com/nektos/act/commit/41f40367663d738a53325745e94a9ec8620b61ff) fix possible leakage of secrets in debug logging - [`dc6d4d5`](https://github.com/nektos/act/commit/dc6d4d5dcb337206b30f1808da2aee2717ad2cdc) fixed %t to masked %s ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+6 -4) </details> ### 📄 Description Found this while browsing the source code. I just thought it was odd to to a regex replace on the string 'true' or 'false' so it caught my attention. I know it's not an important fix but I was here so why not. reference to the commit that originally changed this: https://github.com/nektos/act/commit/4391a10d5a013afb3a4cbc1640eb745132593d7a#diff-4fe45e900ed33a3395bb42c8d8a85c1afb94987b2368bfe31d62e9e1ebd69060R124 <img width="962" height="330" alt="image" src="https://github.com/user-attachments/assets/78502cce-2b2b-41ff-86b8-41e70b923fa3" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2641
No description provided.