[PR #5961] Fix platform parsing to support multiple equals signs #2636

New issue

Open

opened 2026-03-01 22:37:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 22:37:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/5961
Author: @TheRobotCarlson
Created: 10/30/2025
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (1)

2f8ecdf Fix platform parsing to support multiple equals signs

📊 Changes

2 files changed (+84 additions, -3 deletions)

View changed files

📝 cmd/platforms.go (+3 -3)
➕ cmd/platforms_test.go (+81 -0)

📄 Description

Use strings.LastIndex instead of strings.Split to correctly parse platform strings containing multiple equals signs (e.g., runner=fast-disk-network=catthehacker/ubuntu:act-22.04).

This allows the platform key to contain equals signs, splitting only on the last occurrence to separate the key from the value.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/5961 **Author:** [@TheRobotCarlson](https://github.com/TheRobotCarlson) **Created:** 10/30/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2f8ecdf`](https://github.com/nektos/act/commit/2f8ecdf76416662b388816c0c0a81fff32eb6cff) Fix platform parsing to support multiple equals signs ### 📊 Changes **2 files changed** (+84 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/platforms.go` (+3 -3) ➕ `cmd/platforms_test.go` (+81 -0) </details> ### 📄 Description Use strings.LastIndex instead of strings.Split to correctly parse platform strings containing multiple equals signs (e.g., runner=fast-disk-network=catthehacker/ubuntu:act-22.04). This allows the platform key to contain equals signs, splitting only on the last occurrence to separate the key from the value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>