[PR #2664] [MERGED] fix: secret file reading #2542

New issue

Closed

opened 2026-03-01 21:55:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2664
Author: @ChristopherHX
Created: 2/12/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @mergify[bot]

Base: master ← Head: fix-reading-secrets-file

📝 Commits (1)

a0a49a1 fix: secret file reading (#45)

📊 Changes

3 files changed (+42 additions, -8 deletions)

View changed files

📝 cmd/root.go (+10 -8)
➕ cmd/root_test.go (+28 -0)
➕ cmd/testdata/secrets.yml (+4 -0)

📄 Description

do ToUpper for keys not only for cli args
add tests
Working on fixing the missing coverage of the cmd package by adding tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2664 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 2/12/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-reading-secrets-file` --- ### 📝 Commits (1) - [`a0a49a1`](https://github.com/nektos/act/commit/a0a49a13d1f7126a3ab278ad9b7e3e55139ec143) fix: secret file reading (#45) ### 📊 Changes **3 files changed** (+42 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+10 -8) ➕ `cmd/root_test.go` (+28 -0) ➕ `cmd/testdata/secrets.yml` (+4 -0) </details> ### 📄 Description * do ToUpper for keys not only for cli args * add tests * Working on fixing the missing coverage of the cmd package by adding tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2542

No description provided.

Rows
Columns