[PR #2638] [MERGED] parse_env_file discard utf8 bom #2531

New issue

Closed

opened 2026-03-01 21:55:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2638
Author: @ChristopherHX
Created: 1/29/2025
Status: ✅ Merged
Merged: 2/1/2025
Merged by: @mergify[bot]

Base: master ← Head: parse_env_file-discard-utf8-bom

📝 Commits (8)

60c8c84 parse_env_file discard utf8 bom
20c388a add test + apply to GITHUB_PATH as well
0928f4b fix it
befb349 fix powershel 5 syntax
44e2981 misc
8d4fec5 fixup
3e17ef2 fix wrong subaction
9242fbe Merge branch 'master' into parse_env_file-discard-utf8-bom

📊 Changes

7 files changed (+110 additions, -1 deletions)

View changed files

📝 pkg/container/parse_env_file.go (+8 -0)
📝 pkg/runner/run_context.go (+8 -0)
📝 pkg/runner/runner_test.go (+2 -0)
➕ pkg/runner/testdata/windows-add-env-powershell-5/action/action.yml (+7 -0)
➕ pkg/runner/testdata/windows-add-env-powershell-5/push.yml (+48 -0)
📝 pkg/runner/testdata/windows-add-env/push.yml (+3 -1)
➕ pkg/runner/testdata/windows-prepend-path-powershell-5/push.yml (+34 -0)

📄 Description

powershell 5 may add the BOM even when explicitly using utf8
ask for confirmation in gitea discord

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2638 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 2/1/2025 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `parse_env_file-discard-utf8-bom` --- ### 📝 Commits (8) - [`60c8c84`](https://github.com/nektos/act/commit/60c8c84cb110f822f6b99cd4680f3c1a036020cb) parse_env_file discard utf8 bom - [`20c388a`](https://github.com/nektos/act/commit/20c388afe697feace1d9832603d2313720245595) add test + apply to GITHUB_PATH as well - [`0928f4b`](https://github.com/nektos/act/commit/0928f4b9a6bb7a06d2528ac889010a046161d94b) fix it - [`befb349`](https://github.com/nektos/act/commit/befb349409e8eebcf2f6b7fa0ff95dea656bd847) fix powershel 5 syntax - [`44e2981`](https://github.com/nektos/act/commit/44e2981bd83460985d5806a7091d203acd1149b7) misc - [`8d4fec5`](https://github.com/nektos/act/commit/8d4fec53a8ab047b526e145801e09a21b25b4564) fixup - [`3e17ef2`](https://github.com/nektos/act/commit/3e17ef23ee3b6493b77069e4ca3eabd084897748) fix wrong subaction - [`9242fbe`](https://github.com/nektos/act/commit/9242fbe2c2163c554c1cd44191f10c8f661da2ae) Merge branch 'master' into parse_env_file-discard-utf8-bom ### 📊 Changes **7 files changed** (+110 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/parse_env_file.go` (+8 -0) 📝 `pkg/runner/run_context.go` (+8 -0) 📝 `pkg/runner/runner_test.go` (+2 -0) ➕ `pkg/runner/testdata/windows-add-env-powershell-5/action/action.yml` (+7 -0) ➕ `pkg/runner/testdata/windows-add-env-powershell-5/push.yml` (+48 -0) 📝 `pkg/runner/testdata/windows-add-env/push.yml` (+3 -1) ➕ `pkg/runner/testdata/windows-prepend-path-powershell-5/push.yml` (+34 -0) </details> ### 📄 Description * powershell 5 may add the BOM even when explicitly using utf8 * ask for confirmation in gitea discord --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:50 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2531

No description provided.

Rows
Columns