mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #353] Results for expression evaluation in if conditional are differ from the actual #248
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#248
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sarisia on GitHub (Sep 1, 2020).
Original GitHub issue: https://github.com/nektos/act/issues/353
Summary
It seems that GitHub Actions handle any string in
ifconditional astrue, but Act does not.Consider the following workflow:
GitHub Actions result
Full logs taken with `ACTIONS_STEP_DEBUG` flag
Act result
Full logs taken with `--verbose` flag
Just FYI...
If I do
==comparison inifconditional, Act acts as same as GitHub Actions:@jakesylvestre commented on GitHub (Sep 8, 2020):
I'm having a similiar issue. This resolves to false:
if: true || ! contains(toJSON(github.event.commits.*.message), '[ci skip]')"@github-actions[bot] commented on GitHub (Nov 8, 2020):
Issue is stale and will be closed in 7 days unless there is new activity
@torbjornvatn commented on GitHub (Nov 13, 2020):
I'm looking into this as I've made some of the changes made to the parsing of
if:expressions lately.I've added even more test cases and double checking the test cases in a "real" github actions workflow to be certain that Act has the exact same behavior as the real thing.
Hoping to have a PR ready over the weekend @cplee