[PR #2507] [MERGED] add test for listartifacts v4 filter #2468

New issue

Closed

opened 2026-03-01 21:55:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2507
Author: @ChristopherHX
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @mergify[bot]

Base: master ← Head: fix-v4-defect

📝 Commits (4)

e0aabb4 add test for listartifacts v4 filter
f4cf1c9 Update artifacts.yml
81527cd use 32bit ids after cast to double we have a loss
d07f371 Update artifacts.yml

📊 Changes

2 files changed (+47 additions, -3 deletions)

View changed files

📝 pkg/artifacts/arifacts_v4.go (+3 -3)
📝 pkg/artifacts/testdata/v4/artifacts.yml (+44 -0)

📄 Description

fixes a defect of last change

I reviewed my own code today and saw || instead of && resulting in broken artifact matching.

After fixing this I noticed that nodejs truncates the int64 ids so switch to 32bit that fitd in double.

Additionally added an actual test what this change should fix

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2507 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-v4-defect` --- ### 📝 Commits (4) - [`e0aabb4`](https://github.com/nektos/act/commit/e0aabb4a11b288c5e2ec423aaa3bb4f74e16b3df) add test for listartifacts v4 filter - [`f4cf1c9`](https://github.com/nektos/act/commit/f4cf1c90fb32ad60ad06213b58ffeb29a59bea8c) Update artifacts.yml - [`81527cd`](https://github.com/nektos/act/commit/81527cd7e9eec6e383bc86ba69b13f4b26c08aad) use 32bit ids after cast to double we have a loss - [`d07f371`](https://github.com/nektos/act/commit/d07f3710714fbb2fb7442a5559aa35a8fd9455d8) Update artifacts.yml ### 📊 Changes **2 files changed** (+47 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/artifacts/arifacts_v4.go` (+3 -3) 📝 `pkg/artifacts/testdata/v4/artifacts.yml` (+44 -0) </details> ### 📄 Description * fixes a defect of last change I reviewed my own code today and saw `||` instead of `&&` resulting in broken artifact matching. After fixing this I noticed that nodejs truncates the int64 ids so switch to 32bit that fitd in double. Additionally added an actual test what this change should fix --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:35 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2468

No description provided.

Rows
Columns