[PR #2502] [MERGED] fix: prevent unintended input replacement in reusable workflows with workflow_dispatch when using workflow_call #2466

New issue

Closed

opened 2026-03-01 21:55:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2502
Author: @mahmud2011
Created: 10/24/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @mergify[bot]

Base: master ← Head: bugfix/2464

📝 Commits (10+)

6345596 Remove redundant check
598fb40 Add condition to prevent replacing inputs in reusable workflows with workflow_dispatch inputs
e601770 fmt
7ce71d1 Revert "Remove redundant check"
93590da add test
b66a03b Update runner_test.go
c795b38 update label
d90db0a Merge remote-tracking branch 'origin/master' into bugfix/2464
a757c57 Merge remote-tracking branch 'origin/master' into bugfix/2464
9aea624 Merge remote-tracking branch 'origin/master' into bugfix/2464

📊 Changes

4 files changed (+53 additions, -1 deletions)

View changed files

📝 pkg/runner/expression.go (+1 -1)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/.github/workflows/local-reusable-and-dispatch.yml (+30 -0)
➕ pkg/runner/testdata/uses-workflow-defaults/workflow_dispatch.yml (+21 -0)

📄 Description

Closes: https://github.com/nektos/act/issues/2464

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2502 **Author:** [@mahmud2011](https://github.com/mahmud2011) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/2464` --- ### 📝 Commits (10+) - [`6345596`](https://github.com/nektos/act/commit/63455960ec714eea7631a586bcd59bed449739fc) Remove redundant check - [`598fb40`](https://github.com/nektos/act/commit/598fb406d06cbb344a113b05669f756f1db34100) Add condition to prevent replacing inputs in reusable workflows with workflow_dispatch inputs - [`e601770`](https://github.com/nektos/act/commit/e601770b81c6b8b3d7310e48c0164fe006b814e0) fmt - [`7ce71d1`](https://github.com/nektos/act/commit/7ce71d129baa4dd8f4d999410365ed1febbc1a1e) Revert "Remove redundant check" - [`93590da`](https://github.com/nektos/act/commit/93590da6c8b4e30624d17904c43475db18498527) add test - [`b66a03b`](https://github.com/nektos/act/commit/b66a03b7dff90019933083da043853b64b0d40e3) Update runner_test.go - [`c795b38`](https://github.com/nektos/act/commit/c795b38cedbf77ff0426045db6596c4453ad9677) update label - [`d90db0a`](https://github.com/nektos/act/commit/d90db0a1cdcbf12e2dce99ff6de1e08976fcfcba) Merge remote-tracking branch 'origin/master' into bugfix/2464 - [`a757c57`](https://github.com/nektos/act/commit/a757c57b6a186f70c9d6de2c47009ba92fb31b47) Merge remote-tracking branch 'origin/master' into bugfix/2464 - [`9aea624`](https://github.com/nektos/act/commit/9aea6247e558b40dc903a8b8e465992ff5d35828) Merge remote-tracking branch 'origin/master' into bugfix/2464 ### 📊 Changes **4 files changed** (+53 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+1 -1) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/.github/workflows/local-reusable-and-dispatch.yml` (+30 -0) ➕ `pkg/runner/testdata/uses-workflow-defaults/workflow_dispatch.yml` (+21 -0) </details> ### 📄 Description Closes: https://github.com/nektos/act/issues/2464 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2466

No description provided.

Rows
Columns