[PR #2496] [MERGED] fix: tests with validation errors were skipped #2463

New issue

Closed

opened 2026-03-01 21:55:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2496
Author: @ChristopherHX
Created: 10/20/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @mergify[bot]

Base: master ← Head: fix-tests-with-validation-errors-were-skipped

📝 Commits (6)

ebc4203 fix: tests with validation errors were skipped
5e1c788 fixup
d2c1e35 [no ci] fix one test
c58b6d5 fix some tests
5b091a3 fix last test
cb81f6b Merge branch 'master' into fix-tests-with-validation-errors-were-skipped

📊 Changes

12 files changed (+14 additions, -16 deletions)

View changed files

📝 pkg/runner/runner_test.go (+2 -4)
📝 pkg/runner/testdata/actions-environment-and-context-tests/push.yml (+1 -1)
📝 pkg/runner/testdata/inputs-via-env-context/action/action.yml (+0 -0)
📝 pkg/runner/testdata/inputs-via-env-context/push.yml (+1 -1)
📝 pkg/runner/testdata/path-handling/action/action.yml (+0 -0)
📝 pkg/runner/testdata/path-handling/push.yml (+1 -1)
📝 pkg/runner/testdata/shells/bash/push.yml (+2 -2)
📝 pkg/runner/testdata/shells/pwsh/push.yml (+2 -2)
📝 pkg/runner/testdata/shells/python/push.yml (+2 -2)
📝 pkg/runner/testdata/shells/sh/push.yml (+2 -2)
📝 pkg/runner/testdata/windows-add-env/action/action.yml (+0 -0)
📝 pkg/runner/testdata/windows-add-env/push.yml (+1 -1)

📄 Description

Caution

Some tests were broken after workflow schema validation had been added, need to decide what to do and how this impacted merges

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2496 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 10/20/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-tests-with-validation-errors-were-skipped` --- ### 📝 Commits (6) - [`ebc4203`](https://github.com/nektos/act/commit/ebc420305f4536ac56ae9958145a5cbb152a5cd4) fix: tests with validation errors were skipped - [`5e1c788`](https://github.com/nektos/act/commit/5e1c78833fe08604f89a69e3afa9b14b726e05ec) fixup - [`d2c1e35`](https://github.com/nektos/act/commit/d2c1e35817736ecc01c21181820a7cc65a63ded3) [no ci] fix one test - [`c58b6d5`](https://github.com/nektos/act/commit/c58b6d59bee34063f20afa4ef4a34125f3519d29) fix some tests - [`5b091a3`](https://github.com/nektos/act/commit/5b091a3f9dfb8a54023582017547a34b6a8d26b1) fix last test - [`cb81f6b`](https://github.com/nektos/act/commit/cb81f6bde179fb954b077e612b7addfb3eea314c) Merge branch 'master' into fix-tests-with-validation-errors-were-skipped ### 📊 Changes **12 files changed** (+14 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/runner_test.go` (+2 -4) 📝 `pkg/runner/testdata/actions-environment-and-context-tests/push.yml` (+1 -1) 📝 `pkg/runner/testdata/inputs-via-env-context/action/action.yml` (+0 -0) 📝 `pkg/runner/testdata/inputs-via-env-context/push.yml` (+1 -1) 📝 `pkg/runner/testdata/path-handling/action/action.yml` (+0 -0) 📝 `pkg/runner/testdata/path-handling/push.yml` (+1 -1) 📝 `pkg/runner/testdata/shells/bash/push.yml` (+2 -2) 📝 `pkg/runner/testdata/shells/pwsh/push.yml` (+2 -2) 📝 `pkg/runner/testdata/shells/python/push.yml` (+2 -2) 📝 `pkg/runner/testdata/shells/sh/push.yml` (+2 -2) 📝 `pkg/runner/testdata/windows-add-env/action/action.yml` (+0 -0) 📝 `pkg/runner/testdata/windows-add-env/push.yml` (+1 -1) </details> ### 📄 Description > [!CAUTION] > Some tests were broken after workflow schema validation had been added, need to decide what to do and how this impacted merges --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2463

No description provided.

Rows
Columns