[PR #2354] [MERGED] fix: add missing service container health check #2408

New issue

Closed

opened 2026-03-01 21:55:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2354
Author: @ChristopherHX
Created: 6/6/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @mergify[bot]

Base: master ← Head: fix-missing-service-container-health-check

📝 Commits (4)

f55c6c5 fix: Implement missing health ceck for Services
3d8e9e5 Add test case
adc9c8f linter doesn't support min builtin and fix check
52c3d0c Merge branch 'master' into fix-missing-service-container-health-check

📊 Changes

6 files changed (+93 additions, -0 deletions)

View changed files

📝 pkg/container/container_types.go (+9 -0)
📝 pkg/container/docker_run.go (+24 -0)
📝 pkg/container/host_environment.go (+4 -0)
📝 pkg/runner/run_context.go (+36 -0)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/mysql-service-container-with-health-check/push.yml (+19 -0)

📄 Description

Some service container like mysql are slow to start, configuring the optional health check per GitHub Actions Docs can enshure they are ready

GitHub Docs Example based on postgres

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2354 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 6/6/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-missing-service-container-health-check` --- ### 📝 Commits (4) - [`f55c6c5`](https://github.com/nektos/act/commit/f55c6c537d381c5b51cac5bfcb4f4b9be8b49c43) fix: Implement missing health ceck for Services - [`3d8e9e5`](https://github.com/nektos/act/commit/3d8e9e519d6eb791f7fbaadb94457e2484527bfe) Add test case - [`adc9c8f`](https://github.com/nektos/act/commit/adc9c8fe0ab31d4857978e28809669f7066a65c9) linter doesn't support min builtin and fix check - [`52c3d0c`](https://github.com/nektos/act/commit/52c3d0c9d4524f23dd826b844415eec1d46b4524) Merge branch 'master' into fix-missing-service-container-health-check ### 📊 Changes **6 files changed** (+93 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/container_types.go` (+9 -0) 📝 `pkg/container/docker_run.go` (+24 -0) 📝 `pkg/container/host_environment.go` (+4 -0) 📝 `pkg/runner/run_context.go` (+36 -0) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/mysql-service-container-with-health-check/push.yml` (+19 -0) </details> ### 📄 Description Some service container like mysql are slow to start, configuring the optional health check per GitHub Actions Docs can enshure they are ready [GitHub Docs Example based on postgres](https://docs.github.com/en/actions/using-containerized-services/creating-postgresql-service-containers#running-jobs-in-containers) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2408

No description provided.

Rows
Columns