[PR #2348] [MERGED] fix: composite action input pollution #2403

New issue

Closed

opened 2026-03-01 21:55:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2348
Author: @ChristopherHX
Created: 6/3/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @mergify[bot]

Base: master ← Head: fix-composite-input-pollution

📝 Commits (6)

7bd9aea fix: composite action input pollution
f9e0e51 fix run steps
19338df fix missing defaults in post after env cleanup
ef8f565 fix test to make more sense
b67251b Add tests and simplify change
885a7b9 Merge branch 'master' into fix-composite-input-pollution

📊 Changes

16 files changed (+182 additions, -0 deletions)

View changed files

📝 pkg/runner/action.go (+1 -0)
📝 pkg/runner/runner_test.go (+2 -0)
📝 pkg/runner/step.go (+10 -0)
📝 pkg/runner/step_test.go (+1 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/action.yml (+16 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/main.js (+14 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/post.js (+14 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/pre.js (+12 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/composite_action/action.yml (+16 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-collision/push.yml (+10 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/action.yml (+16 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/main.js (+14 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/post.js (+14 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/pre.js (+12 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/composite_action/action.yml (+18 -0)
➕ pkg/runner/testdata/uses-composite-check-for-input-shadowing/push.yml (+12 -0)

📄 Description

~~The full shape of this bug not yet discovered, it's big and needs tests~~

~~and~~ act refuses to use the default for an nodejs input when an composite action has an input with the same name

Fixes #2243

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2348 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 6/3/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-composite-input-pollution` --- ### 📝 Commits (6) - [`7bd9aea`](https://github.com/nektos/act/commit/7bd9aea3d0f25da0543c773b5e3e7be54caee86a) fix: composite action input pollution - [`f9e0e51`](https://github.com/nektos/act/commit/f9e0e51450bc8e8db2e162acd90229e09c953632) fix run steps - [`19338df`](https://github.com/nektos/act/commit/19338df3ba2fa9874424e031d5eb2446398427d8) fix missing defaults in post after env cleanup - [`ef8f565`](https://github.com/nektos/act/commit/ef8f565a06731c8c9ed79bb5e4450b1ae10aa667) fix test to make more sense - [`b67251b`](https://github.com/nektos/act/commit/b67251bd8da66c8522a7c081d417636838f3823c) Add tests and simplify change - [`885a7b9`](https://github.com/nektos/act/commit/885a7b9444cae60e34bb7e9b4b903c59e343855c) Merge branch 'master' into fix-composite-input-pollution ### 📊 Changes **16 files changed** (+182 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action.go` (+1 -0) 📝 `pkg/runner/runner_test.go` (+2 -0) 📝 `pkg/runner/step.go` (+10 -0) 📝 `pkg/runner/step_test.go` (+1 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/action.yml` (+16 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/main.js` (+14 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/post.js` (+14 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/action-with-pre-and-post/pre.js` (+12 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/composite_action/action.yml` (+16 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-collision/push.yml` (+10 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/action.yml` (+16 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/main.js` (+14 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/post.js` (+14 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/action-with-pre-and-post/pre.js` (+12 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/composite_action/action.yml` (+18 -0) ➕ `pkg/runner/testdata/uses-composite-check-for-input-shadowing/push.yml` (+12 -0) </details> ### 📄 Description ~~The full shape of this bug not yet discovered, it's big and needs tests~~ ~~and~~ act refuses to use the default for an nodejs input when an composite action has an input with the same name Fixes #2243 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:18 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:55:24 +03:00

[PR #2403] [MERGED] Bump mergo to v1.0.0 with new module URL #2429

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2403

No description provided.

Rows
Columns