[PR #2281] [MERGED] fix: skip service container for empty image #2370

New issue

Closed

opened 2026-03-01 21:55:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2281
Author: @GitBluub
Created: 4/8/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @mergify[bot]

Base: master ← Head: master

📝 Commits (6)

84fccca fix: skip service container for empty image
ec4f7fc test: add testdata for empty image in services
9bf965e fix: add missing test call
1c5da58 fix: wring test call
8f77412 fix: invalid without expression
279ddb8 Merge branch 'master' into master

📊 Changes

3 files changed (+34 additions, -1 deletions)

View changed files

📝 pkg/runner/run_context.go (+7 -1)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/services-empty-image/push.yaml (+26 -0)

📄 Description

It is used to skip empty image name in services which is the only way to handle conditional services in github action currently, see https://github.com/actions/runner/issues/822
Prints the same information message as well

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2281 **Author:** [@GitBluub](https://github.com/GitBluub) **Created:** 4/8/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`84fccca`](https://github.com/nektos/act/commit/84fccca6cb548f97add3f5ae1a8ec6e76b260a68) fix: skip service container for empty image - [`ec4f7fc`](https://github.com/nektos/act/commit/ec4f7fc2c84e96f1d9eeb3bfc20ab849813389b2) test: add testdata for empty image in services - [`9bf965e`](https://github.com/nektos/act/commit/9bf965e9417f23ba4d80812682c468f6d7a4635b) fix: add missing test call - [`1c5da58`](https://github.com/nektos/act/commit/1c5da581bb2eb645aba06f98d78496fe37115713) fix: wring test call - [`8f77412`](https://github.com/nektos/act/commit/8f77412faab1a96efac1e6ab766f36c92fe1975f) fix: invalid without expression - [`279ddb8`](https://github.com/nektos/act/commit/279ddb822df4d7108ca615d380951b9c9e2fb658) Merge branch 'master' into master ### 📊 Changes **3 files changed** (+34 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+7 -1) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/services-empty-image/push.yaml` (+26 -0) </details> ### 📄 Description It is used to skip empty image name in services which is the only way to handle conditional services in github action currently, see https://github.com/actions/runner/issues/822 Prints the same information message as well --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2370

No description provided.

Rows
Columns