[PR #2266] [MERGED] Use ping to improve network test #2357

New issue

Closed

opened 2026-03-01 21:55:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2266
Author: @wolfogre
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/28/2024
Merged by: @mergify[bot]

Base: master ← Head: bugfix/test_network

📝 Commits (1)

a1392f1 test: use ping to improve network test

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 pkg/runner/testdata/networking/push.yml (+2 -2)

📄 Description

The ping command works well with mDNS, while the host command does not.

To avoid failed tests like:

2024-03-28T07:30:14.5399002Z [test network setup/test] [DEBUG] Working directory '/home/runner/work/act/act/pkg/runner/testdata'
2024-03-28T07:30:14.5399461Z [test network setup/test]   | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net
2024-03-28T07:30:14.5400024Z [test network setup/test]   | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net has address 10.1.0.90
2024-03-28T07:30:14.5400617Z [test network setup/test]   | Host fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net not found: 3(NXDOMAIN)
2024-03-28T07:30:14.5400892Z [test network setup/test]   ❌  Failure - Main Run hostname test
2024-03-28T07:30:14.5401089Z [test network setup/test] exitcode '1': failure
2024-03-28T07:30:14.5401260Z [test network setup/test] 🏁  Job failed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2266 **Author:** [@wolfogre](https://github.com/wolfogre) **Created:** 3/28/2024 **Status:** ✅ Merged **Merged:** 3/28/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/test_network` --- ### 📝 Commits (1) - [`a1392f1`](https://github.com/nektos/act/commit/a1392f1b04052014bcafca763ef39ba9ecbd98b7) test: use ping to improve network test ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/testdata/networking/push.yml` (+2 -2) </details> ### 📄 Description The `ping` command works well with mDNS, while the `host` command does not. To avoid failed tests like: ``` 2024-03-28T07:30:14.5399002Z [test network setup/test] [DEBUG] Working directory '/home/runner/work/act/act/pkg/runner/testdata' 2024-03-28T07:30:14.5399461Z [test network setup/test] | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net 2024-03-28T07:30:14.5400024Z [test network setup/test] | fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net has address 10.1.0.90 2024-03-28T07:30:14.5400617Z [test network setup/test] | Host fv-az1040-512.0dilqmdz4mhurinb4xzj4l1lvc.bx.internal.cloudapp.net not found: 3(NXDOMAIN) 2024-03-28T07:30:14.5400892Z [test network setup/test] ❌ Failure - Main Run hostname test 2024-03-28T07:30:14.5401089Z [test network setup/test] exitcode '1': failure 2024-03-28T07:30:14.5401260Z [test network setup/test] 🏁 Job failed ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2357

No description provided.

Rows
Columns