starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00

[PR #2224] [MERGED] Actions Artifacts v4 backend #2332

New issue

Closed

opened 2026-03-01 21:54:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2224
Author: @ChristopherHX
Created: 2/19/2024
Status: ✅ Merged
Merged: 5/20/2024
Merged by: @mergify[bot]

Base: master ← Head: artifacts-v4

📝 Commits (10+)

dbd3b73 Actions Artifacts v4 backend
325781a lint
f53d8b1 fix it now
9c3c3a9 remove protofile, to make linter not complain
b511927 sync changes
debdad9 add delete
ad925c2 import auth test from gitea
de481dd Merge branch 'master' of github.com:nektos/act into artifacts-v4
664c609 Merge branch 'master' into artifacts-v4
b36d612 Merge branch 'master' into artifacts-v4

📊 Changes

12 files changed (+1836 additions, -37 deletions)

View changed files

📝 codecov.yml (+3 -0)
📝 go.mod (+5 -0)
📝 go.sum (+64 -36)
➕ pkg/artifacts/arifacts_v4.go (+442 -0)
➕ pkg/artifacts/artifact.pb.go (+1058 -0)
📝 pkg/artifacts/server.go (+1 -0)
📝 pkg/artifacts/server_test.go (+1 -0)
➕ pkg/artifacts/testdata/v4/artifacts.yml (+43 -0)
➕ pkg/common/auth.go (+100 -0)
➕ pkg/common/auth_test.go (+62 -0)
📝 pkg/runner/run_context.go (+7 -1)
📝 pkg/runner/run_context_test.go (+50 -0)

📄 Description

A pretty insecure backport with stubs and removed checks

I'm the original author of most code in artifacts_v4.go and the dumped proto code

jwt code is from the gitea project

Use at your own risk

If you want tests, someone else need to take this over.

Tests for the full Gitea Implementation can be found here: https://github.com/go-gitea/gitea/pull/28965

Fixes https://github.com/nektos/act/issues/2135

dumped proto file has been deleted, because I'm not going to make changes to that file to satisfy the linter

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2224 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 2/19/2024 **Status:** ✅ Merged **Merged:** 5/20/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `artifacts-v4` --- ### 📝 Commits (10+) - [`dbd3b73`](https://github.com/nektos/act/commit/dbd3b7333a6e20f33b624de908a66e7b4fcd839a) Actions Artifacts v4 backend - [`325781a`](https://github.com/nektos/act/commit/325781acc6b2159105f82a7fe1d25336dae3ddd6) lint - [`f53d8b1`](https://github.com/nektos/act/commit/f53d8b1933d32ee95c019371b42d23c012838e73) fix it now - [`9c3c3a9`](https://github.com/nektos/act/commit/9c3c3a9a9a9a253ba78496c16ded205261e96be2) remove protofile, to make linter not complain - [`b511927`](https://github.com/nektos/act/commit/b5119276428b537db56061662ef013606b4ebbac) sync changes - [`debdad9`](https://github.com/nektos/act/commit/debdad9684830f74b8e4f26c8f1aa6d665b35817) add delete - [`ad925c2`](https://github.com/nektos/act/commit/ad925c2eca46898bf560d126d0073cf9074a6c3f) import auth test from gitea - [`de481dd`](https://github.com/nektos/act/commit/de481dde3be2bb2a3a2a28057ac3416de8f3ff65) Merge branch 'master' of github.com:nektos/act into artifacts-v4 - [`664c609`](https://github.com/nektos/act/commit/664c609afe9f9a41ff0011b19d0c4f94db3593e0) Merge branch 'master' into artifacts-v4 - [`b36d612`](https://github.com/nektos/act/commit/b36d612fdc304b5288f320569cb1a8075444c5ae) Merge branch 'master' into artifacts-v4 ### 📊 Changes **12 files changed** (+1836 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `codecov.yml` (+3 -0) 📝 `go.mod` (+5 -0) 📝 `go.sum` (+64 -36) ➕ `pkg/artifacts/arifacts_v4.go` (+442 -0) ➕ `pkg/artifacts/artifact.pb.go` (+1058 -0) 📝 `pkg/artifacts/server.go` (+1 -0) 📝 `pkg/artifacts/server_test.go` (+1 -0) ➕ `pkg/artifacts/testdata/v4/artifacts.yml` (+43 -0) ➕ `pkg/common/auth.go` (+100 -0) ➕ `pkg/common/auth_test.go` (+62 -0) 📝 `pkg/runner/run_context.go` (+7 -1) 📝 `pkg/runner/run_context_test.go` (+50 -0) </details> ### 📄 Description A pretty insecure backport with stubs and removed checks I'm the original author of most code in artifacts_v4.go and the dumped proto code jwt code is from the gitea project Use at your own risk If you want tests, someone else need to take this over. Tests for the full Gitea Implementation can be found here: https://github.com/go-gitea/gitea/pull/28965 Fixes https://github.com/nektos/act/issues/2135 **dumped proto file has been deleted, because I'm not going to make changes to that file to satisfy the linter** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:55:16 +03:00

[PR #2332] [MERGED] build(deps): bump github.com/docker/cli from 26.1.2+incompatible to 26.1.3+incompatible #2397

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2332

No description provided.

Rows
Columns