[PR #2200] Dynamic artifact server port #2318

Open
opened 2026-03-01 21:54:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2200
Author: @matthewbaggett
Created: 2/3/2024
Status: 🔄 Open

Base: masterHead: dynamic-artifact-server-port


📝 Commits (3)

  • ffc903e Support dynamic generation of ArtifactServerPort and derived ACTIONS_RUNTIME_URL
  • 01ccdd1 move duplicated, junk-injecting copy of ACTIONS_RUNTIME_URL from run_context.go. Noticed that ACTIONS_RUNTIME_TOKEN is being generated there too, all on its lonesome.. Moved to root.go to keep ACTIONS_RUNTIME_URL company...
  • 3187cbc Merge branch 'master' into dynamic-artifact-server-port

📊 Changes

6 files changed (+27 additions, -32 deletions)

View changed files

📝 cmd/input.go (+1 -1)
📝 cmd/root.go (+13 -2)
📝 pkg/artifacts/server.go (+8 -6)
📝 pkg/artifacts/server_test.go (+4 -4)
📝 pkg/runner/run_context.go (+0 -18)
📝 pkg/runner/runner.go (+1 -1)

📄 Description

This makes --artifact-server-port consistent with --cache-server-port and resolves my own feature request #2192


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2200 **Author:** [@matthewbaggett](https://github.com/matthewbaggett) **Created:** 2/3/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `dynamic-artifact-server-port` --- ### 📝 Commits (3) - [`ffc903e`](https://github.com/nektos/act/commit/ffc903e88df3231ec40aaf5b72c2917e5ad4f3c6) Support dynamic generation of ArtifactServerPort and derived ACTIONS_RUNTIME_URL - [`01ccdd1`](https://github.com/nektos/act/commit/01ccdd137d98873ec56016fa3189064d5a04d167) move duplicated, junk-injecting copy of ACTIONS_RUNTIME_URL from run_context.go. Noticed that ACTIONS_RUNTIME_TOKEN is being generated there too, all on its lonesome.. Moved to root.go to keep ACTIONS_RUNTIME_URL company... - [`3187cbc`](https://github.com/nektos/act/commit/3187cbcba4b3e34df043041d1a176d68d46c01bf) Merge branch 'master' into dynamic-artifact-server-port ### 📊 Changes **6 files changed** (+27 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `cmd/input.go` (+1 -1) 📝 `cmd/root.go` (+13 -2) 📝 `pkg/artifacts/server.go` (+8 -6) 📝 `pkg/artifacts/server_test.go` (+4 -4) 📝 `pkg/runner/run_context.go` (+0 -18) 📝 `pkg/runner/runner.go` (+1 -1) </details> ### 📄 Description This makes `--artifact-server-port` consistent with `--cache-server-port` and resolves my own feature request #2192 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2318
No description provided.