mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[PR #2200] Dynamic artifact server port #2318
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#2318
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/2200
Author: @matthewbaggett
Created: 2/3/2024
Status: 🔄 Open
Base:
master← Head:dynamic-artifact-server-port📝 Commits (3)
ffc903eSupport dynamic generation of ArtifactServerPort and derived ACTIONS_RUNTIME_URL01ccdd1move duplicated, junk-injecting copy of ACTIONS_RUNTIME_URL from run_context.go. Noticed that ACTIONS_RUNTIME_TOKEN is being generated there too, all on its lonesome.. Moved to root.go to keep ACTIONS_RUNTIME_URL company...3187cbcMerge branch 'master' into dynamic-artifact-server-port📊 Changes
6 files changed (+27 additions, -32 deletions)
View changed files
📝
cmd/input.go(+1 -1)📝
cmd/root.go(+13 -2)📝
pkg/artifacts/server.go(+8 -6)📝
pkg/artifacts/server_test.go(+4 -4)📝
pkg/runner/run_context.go(+0 -18)📝
pkg/runner/runner.go(+1 -1)📄 Description
This makes
--artifact-server-portconsistent with--cache-server-portand resolves my own feature request #2192🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.