[PR #2180] [CLOSED] chore: Socket logic consolidation #2309

New issue

Closed

opened 2026-03-01 21:54:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2180
Author: @AndesKrrrrrrrrrrr
Created: 1/30/2024
Status: ❌ Closed

Base: master ← Head: chore/socket-logic-consolidation

📝 Commits (10+)

cf9e9cb Use same socket defaulting strategy every time
1f43b1f Always default to DOCKER_HOST
da1907a Add more debug logs
51da536 Commenting, and massively simplified socket logic
06368a5 Rever to upstream run_context.go
cabec66 Merge branch 'master' into master
b2a8394 Fix EACCESS error regarding /opt/hostedtoolcache
f87dd97 Revert "Fix EACCESS error regarding /opt/hostedtoolcache"
037dc45 Merge branch 'master' into master
0975df3 Move all socket lookup and defaulting logic to the same place

📊 Changes

5 files changed (+88 additions, -71 deletions)

View changed files

📝 cmd/root.go (+21 -48)
📝 pkg/container/docker_cli.go (+2 -0)
📝 pkg/container/docker_run.go (+6 -0)
📝 pkg/container/util.go (+55 -2)
📝 pkg/runner/run_context.go (+4 -21)

📄 Description

Depends on #2179

Attempt at moving all logic regarding the docker socket location to a single place, to prevent duplication and human error when needing to edit in multiple places.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2180 **Author:** [@AndesKrrrrrrrrrrr](https://github.com/AndesKrrrrrrrrrrr) **Created:** 1/30/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `chore/socket-logic-consolidation` --- ### 📝 Commits (10+) - [`cf9e9cb`](https://github.com/nektos/act/commit/cf9e9cb898052f196d18fcb3f130ce77ff55fd08) Use same socket defaulting strategy every time - [`1f43b1f`](https://github.com/nektos/act/commit/1f43b1fbe5eeec50ab81c030b89926d00740b3ff) Always default to DOCKER_HOST - [`da1907a`](https://github.com/nektos/act/commit/da1907ab1c544f0bb293b3581f87e854955f75f6) Add more debug logs - [`51da536`](https://github.com/nektos/act/commit/51da53631aa2498848868b76181b8dfe51c90832) Commenting, and massively simplified socket logic - [`06368a5`](https://github.com/nektos/act/commit/06368a551928e56bbac7e5fd8674f044798d18a3) Rever to upstream run_context.go - [`cabec66`](https://github.com/nektos/act/commit/cabec6625fc3898d0baf166a12e8a0b0dfcf2503) Merge branch 'master' into master - [`b2a8394`](https://github.com/nektos/act/commit/b2a8394d3358e1b5aab9dabe555d4a3f2bf0b2f9) Fix EACCESS error regarding /opt/hostedtoolcache - [`f87dd97`](https://github.com/nektos/act/commit/f87dd97d3d59b6059a74791687591284aff51e7e) Revert "Fix EACCESS error regarding /opt/hostedtoolcache" - [`037dc45`](https://github.com/nektos/act/commit/037dc450d4f55dee2133488d864c11b9bae9e8cd) Merge branch 'master' into master - [`0975df3`](https://github.com/nektos/act/commit/0975df39cf25e11477137ae76f84df3a39dbbc31) Move all socket lookup and defaulting logic to the same place ### 📊 Changes **5 files changed** (+88 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+21 -48) 📝 `pkg/container/docker_cli.go` (+2 -0) 📝 `pkg/container/docker_run.go` (+6 -0) 📝 `pkg/container/util.go` (+55 -2) 📝 `pkg/runner/run_context.go` (+4 -21) </details> ### 📄 Description Depends on #2179 Attempt at moving all logic regarding the docker socket location to a single place, to prevent duplication and human error when needing to edit in multiple places. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:53 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:55:13 +03:00

[PR #2309] [MERGED] build(deps): bump megalinter/megalinter from 7.10.0 to 7.11.1 #2385

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2309

No description provided.

Rows
Columns