[PR #2174] [MERGED] refactor: filecollector into new package #2304

New issue

Closed

opened 2026-03-01 21:54:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2174
Author: @ChristopherHX
Created: 1/28/2024
Status: ✅ Merged
Merged: 1/30/2024
Merged by: @mergify[bot]

Base: master ← Head: refactor-filecollector-into-new-package

📝 Commits (5)

6d3c6e6 refactor: filecollector into new package
164f338 Merge branch 'master' into refactor-filecollector-into-new-package
a591709 Add test for symlinks
9a8c5ce add test fix bug of GetContainerArchive
43b091b add test data

📊 Changes

6 files changed (+160 additions, -35 deletions)

View changed files

📝 pkg/container/docker_run.go (+5 -4)
📝 pkg/container/host_environment.go (+11 -10)
📝 pkg/container/host_environment_test.go (+67 -0)
➕ pkg/container/testdata/scratch/test.txt (+1 -0)
📝 pkg/filecollector/file_collector.go (+17 -17)
📝 pkg/filecollector/file_collector_test.go (+59 -4)

📄 Description

To be able to reuse this logic across packages it makes sense for me to export it and move this into a new package.

This helps to remove the copy of filecollector in https://github.com/nektos/act/pull/2155

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2174 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 1/28/2024 **Status:** ✅ Merged **Merged:** 1/30/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor-filecollector-into-new-package` --- ### 📝 Commits (5) - [`6d3c6e6`](https://github.com/nektos/act/commit/6d3c6e6820abaed41e3ec9d5049ee308e7eb81cb) refactor: filecollector into new package - [`164f338`](https://github.com/nektos/act/commit/164f338ac49104059267edc892ee73e615043cf1) Merge branch 'master' into refactor-filecollector-into-new-package - [`a591709`](https://github.com/nektos/act/commit/a5917092f00b4134e8a4f4c481f3f17beab9abe9) Add test for symlinks - [`9a8c5ce`](https://github.com/nektos/act/commit/9a8c5cec90487ad58ea8caaaeca1dbad648edeba) add test fix bug of GetContainerArchive - [`43b091b`](https://github.com/nektos/act/commit/43b091bdb594e47f888287d42972e8ba91ada15c) add test data ### 📊 Changes **6 files changed** (+160 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+5 -4) 📝 `pkg/container/host_environment.go` (+11 -10) 📝 `pkg/container/host_environment_test.go` (+67 -0) ➕ `pkg/container/testdata/scratch/test.txt` (+1 -0) 📝 `pkg/filecollector/file_collector.go` (+17 -17) 📝 `pkg/filecollector/file_collector_test.go` (+59 -4) </details> ### 📄 Description To be able to reuse this logic across packages it makes sense for me to export it and move this into a new package. This helps to remove the copy of filecollector in <https://github.com/nektos/act/pull/2155> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2304

No description provided.

Rows
Columns