[PR #2168] [MERGED] Add containerd's normalized architectures to archMapper #2299

New issue

Closed

opened 2026-03-01 21:54:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2168
Author: @MatthewCash
Created: 1/22/2024
Status: ✅ Merged
Merged: 1/24/2024
Merged by: @mergify[bot]

Base: master ← Head: fix/add-containerd-archs

📝 Commits (1)

c457c40 Add containerd's normalized architectures to archMapper

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 pkg/container/docker_run.go (+2 -0)

📄 Description

While Docker gets its architecture property from utsname.machine, Podman uses containerd's normalizeArch function which returns an architecture not in act's archMapper map, leading to the architecture to be passed through to the runner. This causes some runners to fail if they expect the architecture to only be in GitHub's format.

I added the two missing entries from normalizearch, amd64 and arm64, to archMapper.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2168 **Author:** [@MatthewCash](https://github.com/MatthewCash) **Created:** 1/22/2024 **Status:** ✅ Merged **Merged:** 1/24/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/add-containerd-archs` --- ### 📝 Commits (1) - [`c457c40`](https://github.com/nektos/act/commit/c457c40b7b01ca7df91638bccd22f873a38fb388) Add containerd's normalized architectures to archMapper ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+2 -0) </details> ### 📄 Description While Docker gets its architecture property from `utsname.machine`, Podman uses `containerd`'s `normalizeArch` function which returns an architecture not in act's `archMapper` map, leading to the architecture to be passed through to the runner. This causes some runners to fail if they expect the architecture to only be in GitHub's format. I added the two missing entries from [`normalizearch`](https://github.com/containerd/containerd/blob/be9336fed1a2e5570061da2998a201b111cf22c5/platforms/database.go#L79-L106), `amd64` and `arm64`, to `archMapper`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:51 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:55:12 +03:00

[PR #2299] [MERGED] build(deps): bump github.com/docker/docker from 26.0.1+incompatible to 26.0.2+incompatible #2378

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2299

No description provided.

Rows
Columns