starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00

[PR #2102] [MERGED] Fix noisy `runs-on` error logging #2269

New issue

Closed

opened 2026-03-01 21:54:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2102
Author: @jenseng
Created: 11/23/2023
Status: ✅ Merged
Merged: 12/16/2023
Merged by: @mergify[bot]

Base: master ← Head: fix-runs-on-error-logging

📝 Commits (3)

1cd1a0e Fix noisy runs-on error logging
cec06c5 Merge branch 'master' into fix-runs-on-error-logging
676db9a Merge branch 'master' into fix-runs-on-error-logging

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 pkg/runner/run_context.go (+4 -1)

📄 Description

Move the logging back up a level to fix a minor logging issue introduced in #2088

The RunContext for a composite action has a dummy/blank Job with no runs-on, meaning its calls to withGithubEnv would result in an inaccurate log message complaining that 'runs-on' key not defined in ...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2102 **Author:** [@jenseng](https://github.com/jenseng) **Created:** 11/23/2023 **Status:** ✅ Merged **Merged:** 12/16/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-runs-on-error-logging` --- ### 📝 Commits (3) - [`1cd1a0e`](https://github.com/nektos/act/commit/1cd1a0ea9772e0d55d4ff43d4efd09e0158b4a6a) Fix noisy `runs-on` error logging - [`cec06c5`](https://github.com/nektos/act/commit/cec06c5c06fda264c9d90d84d639335a84e1a7b8) Merge branch 'master' into fix-runs-on-error-logging - [`676db9a`](https://github.com/nektos/act/commit/676db9aa4d01df8cdc2326f8b0797338391ba267) Merge branch 'master' into fix-runs-on-error-logging ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+4 -1) </details> ### 📄 Description Move the logging back up a level to fix a minor logging issue introduced in #2088 The `RunContext` for a composite action has a dummy/blank `Job` with no `runs-on`, meaning its calls to `withGithubEnv` would result in an inaccurate log message complaining that `'runs-on' key not defined in ...` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:43 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:55:07 +03:00

[PR #2269] [MERGED] build(deps): bump github.com/go-git/go-git/v5 from 5.11.0 to 5.12.0 #2358

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2269

No description provided.

Rows
Columns

[PR #2102] [MERGED] Fix noisy runs-on error logging #2269

📋 Pull Request Information

📝 Commits (3)

📊 Changes

📄 Description

[PR #2102] [MERGED] Fix noisy `runs-on` error logging #2269