[PR #2093] [MERGED] fix: IsHost is defined as false on windows #2263

New issue

Closed

opened 2026-03-01 21:54:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2093
Author: @ChristopherHX
Created: 11/14/2023
Status: ✅ Merged
Merged: 12/16/2023
Merged by: @nektos-ci

Base: master ← Head: ishost-and-isuserdefined-are-broken

📝 Commits (5)

a2184b6 fix: IsHost is defined as false on windows
d6ff3fb Update docker_run.go
063c8cf Update docker_run.go
79c7caf Merge branch 'master' into ishost-and-isuserdefined-are-broken
274a246 Merge branch 'master' into ishost-and-isuserdefined-are-broken

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 pkg/container/docker_run.go (+2 -4)

📄 Description

Sorry the last change didn't work.

However it would be useful to not comment it works if you didn't tested it.

Maybe fixes #2074

IsHost is even defined to false on windows, the host default of act makes the docker cli/api package buggy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2093 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 11/14/2023 **Status:** ✅ Merged **Merged:** 12/16/2023 **Merged by:** [@nektos-ci](https://github.com/nektos-ci) **Base:** `master` ← **Head:** `ishost-and-isuserdefined-are-broken` --- ### 📝 Commits (5) - [`a2184b6`](https://github.com/nektos/act/commit/a2184b6e815bdb7434549fac9257fb5fa1a57ea9) fix: IsHost is defined as false on windows - [`d6ff3fb`](https://github.com/nektos/act/commit/d6ff3fb16dad515a42e232f450b3359fc30763c8) Update docker_run.go - [`063c8cf`](https://github.com/nektos/act/commit/063c8cf945c65a98752ff5660149c74af37047df) Update docker_run.go - [`79c7caf`](https://github.com/nektos/act/commit/79c7caf4212c274f4b86308f27f2737f52244bd3) Merge branch 'master' into ishost-and-isuserdefined-are-broken - [`274a246`](https://github.com/nektos/act/commit/274a246872c720cfb2e7c7f68acee4413508afe5) Merge branch 'master' into ishost-and-isuserdefined-are-broken ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+2 -4) </details> ### 📄 Description Sorry the last change didn't work. However it would be useful to not comment it works if you didn't tested it. Maybe fixes #2074 IsHost is even defined to false on windows, the host default of act makes the docker cli/api package buggy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2263

No description provided.

Rows
Columns