[PR #2088] [MERGED] Support array expressions in runs-on #2262

New issue

Closed

opened 2026-03-01 21:54:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2088
Author: @jenseng
Created: 11/11/2023
Status: ✅ Merged
Merged: 11/12/2023
Merged by: @mergify[bot]

Base: master ← Head: runs-on-array-expression

📝 Commits (3)

aa51d8c Support array expressions in runs-on
2881f78 Simplify appproach to use EvaluateYamlNode, fix case-sensitivity bug
6909443 Merge branch 'master' into runs-on-array-expression

📊 Changes

3 files changed (+66 additions, -17 deletions)

View changed files

📝 cmd/platforms.go (+1 -1)
📝 pkg/runner/run_context.go (+18 -16)
📝 pkg/runner/run_context_test.go (+47 -0)

📄 Description

Ensure array expressions in runs-on are handled correctly. Also fix -P to work case-insensitively, since labels are not case sensitive.

There is still one outstanding issue with runs-on and expressions, but that is not new to this PR: a matrix with a templated runs-on (e.g. runs-on: ${{ matrix.label }}). That feels like a bigger fix/refactor, so I was thinking of filing a new issue issue/PR for that, but if you'd prefer I can incorporate it into this one.

Fixes #2080

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2088 **Author:** [@jenseng](https://github.com/jenseng) **Created:** 11/11/2023 **Status:** ✅ Merged **Merged:** 11/12/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `runs-on-array-expression` --- ### 📝 Commits (3) - [`aa51d8c`](https://github.com/nektos/act/commit/aa51d8c3af1738bc84e04e878773bdafc5482774) Support array expressions in runs-on - [`2881f78`](https://github.com/nektos/act/commit/2881f7899599de7b1a71f3512ebb62275cde88d3) Simplify appproach to use EvaluateYamlNode, fix case-sensitivity bug - [`6909443`](https://github.com/nektos/act/commit/69094438b63a4e2fcf4d95784bf26f337efd80c7) Merge branch 'master' into runs-on-array-expression ### 📊 Changes **3 files changed** (+66 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `cmd/platforms.go` (+1 -1) 📝 `pkg/runner/run_context.go` (+18 -16) 📝 `pkg/runner/run_context_test.go` (+47 -0) </details> ### 📄 Description Ensure array expressions in `runs-on` are handled correctly. Also fix `-P` to work case-insensitively, since labels are not case sensitive. There is still one outstanding issue with `runs-on` and expressions, but that is not new to this PR: a matrix with a templated runs-on (e.g. `runs-on: ${{ matrix.label }}`). That feels like a bigger fix/refactor, so I was thinking of filing a new issue issue/PR for that, but if you'd prefer I can incorporate it into this one. Fixes #2080 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:41 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2262

No description provided.

Rows
Columns