starred/act
1
0
Fork 0
mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00
Code Issues 289 Projects Releases 5 Packages Wiki Activity

[PR #2071] [MERGED] Fix panic in extractFromImageEnv #2260

New issue
Closed
opened 2026-03-01 21:54:41 +03:00 by kerem · 0 comments
kerem commented 2026-03-01 21:54:41 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2071
Author: @wolfogre
Created: 10/31/2023
Status: ✅ Merged
Merged: 11/4/2023
Merged by: @mergify[bot]

Base: master ← Head: bugfix/panic_extractFromImageEnv

📝 Commits (2)

  • ec399da fix: panic
  • 9e4d7c9 Merge branch 'master' into bugfix/panic_extractFromImageEnv

📊 Changes

1 file changed (+14 additions, -11 deletions)

View changed files

📝 pkg/container/docker_run.go (+14 -11)

📄 Description

Panic log:

[Build and Publish Docs site/build-docs] Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.42/images/node:16-bullseye/json": context deadline exceeded
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0xb5e0e1]
goroutine 617134 [running]:
github.com/nektos/act/pkg/container.(*containerReference).UpdateFromImageEnv.(*containerReference).extractFromImageEnv.func1({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/container/docker_run.go:528 +0x1e1
github.com/nektos/act/pkg/container.(*containerReference).UpdateFromImageEnv.Executor.IfNot.func2({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:166 +0x4f
github.com/nektos/act/pkg/runner.(*RunContext).ApplyExtraPath(0xc000334b40, {0xefd3a8, 0xc000a315f0}, 0xc000292f38)
        github.com/nektos/act@v0.2.51/pkg/runner/run_context.go:416 +0x204
github.com/nektos/act/pkg/runner.(*stepActionRemote).post.runPostStep.func1({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/runner/action.go:656 +0x891
github.com/nektos/act/pkg/runner.(*stepActionRemote).post.runStepExecutor.func2({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/runner/step.go:141 +0xd83
github.com/nektos/act/pkg/runner.(*stepActionRemote).post.Executor.If.func4({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:156 +0x45
github.com/nektos/act/pkg/runner.(*stepActionRemote).post.Executor.If.func6({0xefd3a8, 0xc000a315f0})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:156 +0x45
github.com/nektos/act/pkg/runner.newJobExecutor.useStepLogger.func12({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/runner/job_executor.go:225 +0x2e2
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func14({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31
github.com/nektos/act/pkg/runner.newJobExecutor.func7({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/runner/job_executor.go:159 +0xe2
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func16({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func17({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31
github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func18({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31
github.com/nektos/act/pkg/runner.newJobExecutor.NewPipelineExecutor.Executor.Then.func21({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:148 +0x142
github.com/nektos/act/pkg/runner.(*RunContext).Executor.func1({0xefd3a8, 0xc0020baa20})
        github.com/nektos/act@v0.2.51/pkg/runner/run_context.go:595 +0x50
github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.1({0xefd3a8, 0xc00009d890})
        github.com/nektos/act@v0.2.51/pkg/runner/runner.go:214 +0x19a
github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.func2.1(0x8f4ba5?, 0xc000126c60?)
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:107 +0x52
created by github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.func2 in goroutine 617133
        github.com/nektos/act@v0.2.51/pkg/common/executor.go:105 +0xf7

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2071 **Author:** [@wolfogre](https://github.com/wolfogre) **Created:** 10/31/2023 **Status:** ✅ Merged **Merged:** 11/4/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/panic_extractFromImageEnv` --- ### 📝 Commits (2) - [`ec399da`](https://github.com/nektos/act/commit/ec399da48168ff32ebc67045605e21b8d4f59810) fix: panic - [`9e4d7c9`](https://github.com/nektos/act/commit/9e4d7c90e2305e5bc1f64c5bca15b8123309f133) Merge branch 'master' into bugfix/panic_extractFromImageEnv ### 📊 Changes **1 file changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+14 -11) </details> ### 📄 Description Panic log: ```txt [Build and Publish Docs site/build-docs] Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.42/images/node:16-bullseye/json": context deadline exceeded panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0xb5e0e1] goroutine 617134 [running]: github.com/nektos/act/pkg/container.(*containerReference).UpdateFromImageEnv.(*containerReference).extractFromImageEnv.func1({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/container/docker_run.go:528 +0x1e1 github.com/nektos/act/pkg/container.(*containerReference).UpdateFromImageEnv.Executor.IfNot.func2({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:166 +0x4f github.com/nektos/act/pkg/runner.(*RunContext).ApplyExtraPath(0xc000334b40, {0xefd3a8, 0xc000a315f0}, 0xc000292f38) github.com/nektos/act@v0.2.51/pkg/runner/run_context.go:416 +0x204 github.com/nektos/act/pkg/runner.(*stepActionRemote).post.runPostStep.func1({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/runner/action.go:656 +0x891 github.com/nektos/act/pkg/runner.(*stepActionRemote).post.runStepExecutor.func2({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/runner/step.go:141 +0xd83 github.com/nektos/act/pkg/runner.(*stepActionRemote).post.Executor.If.func4({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:156 +0x45 github.com/nektos/act/pkg/runner.(*stepActionRemote).post.Executor.If.func6({0xefd3a8, 0xc000a315f0}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:156 +0x45 github.com/nektos/act/pkg/runner.newJobExecutor.useStepLogger.func12({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/runner/job_executor.go:225 +0x2e2 github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func13({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func14({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31 github.com/nektos/act/pkg/runner.newJobExecutor.func7({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/runner/job_executor.go:159 +0xe2 github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func16({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:183 +0x4f github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func17({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31 github.com/nektos/act/pkg/runner.newJobExecutor.Executor.Finally.func18({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:182 +0x31 github.com/nektos/act/pkg/runner.newJobExecutor.NewPipelineExecutor.Executor.Then.func21({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/common/executor.go:148 +0x142 github.com/nektos/act/pkg/runner.(*RunContext).Executor.func1({0xefd3a8, 0xc0020baa20}) github.com/nektos/act@v0.2.51/pkg/runner/run_context.go:595 +0x50 github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.1({0xefd3a8, 0xc00009d890}) github.com/nektos/act@v0.2.51/pkg/runner/runner.go:214 +0x19a github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.func2.1(0x8f4ba5?, 0xc000126c60?) github.com/nektos/act@v0.2.51/pkg/common/executor.go:107 +0x52 created by github.com/nektos/act/pkg/runner.(*runnerImpl).NewPlanExecutor.func1.NewParallelExecutor.func2 in goroutine 617133 github.com/nektos/act@v0.2.51/pkg/common/executor.go:105 +0xf7 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:54:41 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/github.com/go-git/go-git/v5-5.18.0
dependabot/go_modules/dependencies-08815e2262
mergify/configuration-deprecated-update
dependabot/github_actions/dependencies-a3a104477f
chore/simplify-ci-and-makefile
dependabot/go_modules/golang.org/x/crypto-0.45.0
dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0
panekj/ci/improve-jobs
fix-skip-non-yaml-files-in-dir
normalize-pull-rebuild-flags
fix-no-recurse-by-default
2517-poor-error-for-incomplete-action-step
2472-make-use-new-action-cache-the-new-default-for-downloading-actions
act-tart
act-lxc
act-oidc
act-dind
avoid-slash-in-actor
dependabot/go_modules/github.com/docker/docker-26.1.4incompatible
meta-keep-filetime
local-repository-action-cache
pr-merger
update-docker-deps
follow_local_action_symlink
boltdb-lock-in-handler
use-socket-path
no-pull-no-rebuild
path-issues
fix/env
feat/podman
refactor/testdata
v0.2.87
v0.2.86
v0.2.85
v0.2.84
v0.2.83
v0.2.82
v0.2.81
v0.2.80
v0.2.79
v0.2.78
v0.2.77
v0.2.76
v0.2.75
v0.2.74
v0.2.73
v0.2.72
v0.2.71
v0.2.70
v0.2.69
v0.2.68
v0.2.67
v0.2.66
v0.2.65
v0.2.64
v0.2.63
v0.2.62
v0.2.61
v0.2.60
v0.2.59
v0.2.58
v0.2.57
v0.2.56
v0.2.55
v0.2.54
v0.2.53
v0.2.52
v0.2.51
v0.2.50
v0.2.49
v0.2.48
v0.2.47
v0.2.46
v0.2.45
v0.2.44
v0.2.43
v0.2.42
v0.2.41
v0.2.40
v0.2.39
v0.2.38
v0.2.37
v0.2.36
v0.2.35
v0.2.34
v0.2.33
v0.2.32
v0.2.31
v0.2.30
v0.2.29
v0.2.28
v0.2.27
v0.2.26
v0.2.25
v0.2.24
v0.2.23
v0.2.22
v0.2.21
v0.2.20
v0.2.19
v0.2.18
v0.2.17
v0.2.16
v0.2.15
v0.2.14
v0.2.13
v0.2.12
v0.2.11
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
area/action

   
area/cli

   
area/docs

   
area/image

   
area/runner

   
area/workflow

   
backlog

   
confirmed/not-planned

   
kind/bug

   
kind/discussion

   
kind/external

   
kind/feature-request

   
kind/question

   
meta/duplicate

   
meta/invalid

   
meta/need-more-info

   
meta/resolved

   
meta/wontfix

   
meta/workaround

   
needs-work

   
pull-request

Mirrored from GitHub Pull Request

  
review/not-planned

   
size/M

   
size/XL

   
size/XXL

   
stale

   
stale-exempt
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2260
No description provided.