mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[PR #2020] [MERGED] fix github.action_ref / github.job (composite action) #2234
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#2234
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/2020
Author: @ChristopherHX
Created: 9/22/2023
Status: ✅ Merged
Merged: 10/3/2023
Merged by: @mergify[bot]
Base:
master← Head:fix-actionRepository-actionRef-comp📝 Commits (2)
f0b7194fix action_ref (composite action)98fa122Merge branch 'master' into fix-actionRepository-actionRef-comp📊 Changes
4 files changed (+16 additions, -2 deletions)
View changed files
📝
pkg/runner/action_composite.go(+5 -2)📝
pkg/runner/run_context.go(+2 -0)📝
pkg/runner/runner_test.go(+1 -0)➕
pkg/runner/testdata/remote-action-composite-action-ref/push.yml(+8 -0)📄 Description
I'm burning my fingers by touching this. The test avoid future regression, since it has never been covered by tests in the past.
I know that GITHUB_ACTION_REPOSITORY and GITHUB_ACTION_REF are not defined for composite actions like
INPUT_<name>, but not everyone wanted to archive 100% compatibilityFixes #2019
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.