[PR #2020] [MERGED] fix github.action_ref / github.job (composite action) #2234

Closed
opened 2026-03-01 21:54:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2020
Author: @ChristopherHX
Created: 9/22/2023
Status: Merged
Merged: 10/3/2023
Merged by: @mergify[bot]

Base: masterHead: fix-actionRepository-actionRef-comp


📝 Commits (2)

  • f0b7194 fix action_ref (composite action)
  • 98fa122 Merge branch 'master' into fix-actionRepository-actionRef-comp

📊 Changes

4 files changed (+16 additions, -2 deletions)

View changed files

📝 pkg/runner/action_composite.go (+5 -2)
📝 pkg/runner/run_context.go (+2 -0)
📝 pkg/runner/runner_test.go (+1 -0)
pkg/runner/testdata/remote-action-composite-action-ref/push.yml (+8 -0)

📄 Description

I'm burning my fingers by touching this. The test avoid future regression, since it has never been covered by tests in the past.

I know that GITHUB_ACTION_REPOSITORY and GITHUB_ACTION_REF are not defined for composite actions like INPUT_<name>, but not everyone wanted to archive 100% compatibility

Fixes #2019


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2020 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 9/22/2023 **Status:** ✅ Merged **Merged:** 10/3/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-actionRepository-actionRef-comp` --- ### 📝 Commits (2) - [`f0b7194`](https://github.com/nektos/act/commit/f0b719486bd8170589feed7a34cf273f5ba1d79a) fix action_ref (composite action) - [`98fa122`](https://github.com/nektos/act/commit/98fa122ed982f34d1eb4ce91b16896a4b092df90) Merge branch 'master' into fix-actionRepository-actionRef-comp ### 📊 Changes **4 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action_composite.go` (+5 -2) 📝 `pkg/runner/run_context.go` (+2 -0) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/remote-action-composite-action-ref/push.yml` (+8 -0) </details> ### 📄 Description I'm burning my fingers by touching this. The test avoid future regression, since it has never been covered by tests in the past. _I know that GITHUB_ACTION_REPOSITORY and GITHUB_ACTION_REF are not defined for composite actions like `INPUT_<name>`, but not everyone wanted to archive 100% compatibility_ Fixes #2019 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:54:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2234
No description provided.