[PR #1970] [MERGED] fix: fail if no stages were found #2215

New issue

Closed

opened 2026-03-01 21:54:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1970
Author: @ctrlaltf24
Created: 8/15/2023
Status: ✅ Merged
Merged: 8/21/2023
Merged by: @mergify[bot]

Base: master ← Head: user-facing-debug-error-when-silly

📝 Commits (4)

226adf1 fix: fail if no stages were found
e98f437 Revert "fix: fail if no stages were found"
2b62fba fix: fail if no stages were found
e6a2177 Merge branch 'master' into user-facing-debug-error-when-silly

📊 Changes

2 files changed (+24 additions, -4 deletions)

View changed files

📝 pkg/model/planner.go (+2 -4)
📝 pkg/model/planner_test.go (+22 -0)

📄 Description

Adds a warning message if act is cannot find any stages to run with the filters provided.

Reproduction:

run act -j gibberish

Desired behavior: some indication I did something silly
Actual behavior: no output, just exit with success.

As a human who often makes spelling mistakes,
it would be nice if act warned me what I was doing that was silly rather than exiting apparently doing
nothing with no obvious indication
I did something wrong.

Alternative solutions:

Do nothing, it's the user's fault: True it is, would be nice to give them a hint where to resolve their issue
Exit with error rather than warn: Reasonable behavior as well, not knowledgeable enough with the code base to know for sure this is enough justification to exit

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1970 **Author:** [@ctrlaltf24](https://github.com/ctrlaltf24) **Created:** 8/15/2023 **Status:** ✅ Merged **Merged:** 8/21/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `user-facing-debug-error-when-silly` --- ### 📝 Commits (4) - [`226adf1`](https://github.com/nektos/act/commit/226adf1c15cf4c01d516a05dc923507e6999978d) fix: fail if no stages were found - [`e98f437`](https://github.com/nektos/act/commit/e98f437283dcd4468ec381ae52b1b91f8769cd86) Revert "fix: fail if no stages were found" - [`2b62fba`](https://github.com/nektos/act/commit/2b62fbacd034c5e736e7f3b54a411a7d2b171060) fix: fail if no stages were found - [`e6a2177`](https://github.com/nektos/act/commit/e6a2177ede44891deb84acbe95eb0e3385c5eb27) Merge branch 'master' into user-facing-debug-error-when-silly ### 📊 Changes **2 files changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/planner.go` (+2 -4) 📝 `pkg/model/planner_test.go` (+22 -0) </details> ### 📄 Description Adds a warning message if act is cannot find any stages to run with the filters provided. Reproduction: - run `act -j gibberish` Desired behavior: some indication I did something silly Actual behavior: no output, just exit with success. As a human who often makes spelling mistakes, it would be nice if act warned me what I was doing that was silly rather than exiting apparently doing nothing with no obvious indication I did something wrong. Alternative solutions: - Do nothing, it's the user's fault: True it is, would be nice to give them a hint where to resolve their issue - Exit with error rather than warn: Reasonable behavior as well, not knowledgeable enough with the code base to know for sure this is enough justification to exit --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:29 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:59 +03:00

[PR #2215] [MERGED] build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 #2330

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2215

No description provided.

Rows
Columns