starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00

[PR #1957] [MERGED] fix: "Unknown server OS" for Docker container `--device` option #2210

New issue

Closed

opened 2026-03-01 21:54:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1957
Author: @eliandoran
Created: 8/9/2023
Status: ✅ Merged
Merged: 8/9/2023
Merged by: @mergify[bot]

Base: master ← Head: fix/unknown_server_os_for_docker_device_option

📝 Commits (1)

0b0c346 Fix "Unknown server OS" for Docker container --device option

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/container/docker_run.go (+1 -1)

📄 Description

The --device option would do platform-dependent validation, but the OS was not passed as an argument. When a user added the --device option to the container, it would result in a "Unknown server OS" error.

Fixes #1910.

Sample YAML to reproduce it:

jobs:
  build:
    name: Foo
    container:
      image: bar:latest
      options: -uroot --device=/dev/bus/usb/001/002

I would prefer to write a test for this fix, but I'm not very familiar with the project or the programming language.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1957 **Author:** [@eliandoran](https://github.com/eliandoran) **Created:** 8/9/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/unknown_server_os_for_docker_device_option` --- ### 📝 Commits (1) - [`0b0c346`](https://github.com/nektos/act/commit/0b0c3461e10b6e1062a9237e0037572856b9a96d) Fix "Unknown server OS" for Docker container `--device` option ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+1 -1) </details> ### 📄 Description The `--device` option would do platform-dependent validation, but the OS was not passed as an argument. When a user added the `--device` option to the container, it would result in a "Unknown server OS" error. Fixes #1910. Sample YAML to reproduce it: ```yml jobs: build: name: Foo container: image: bar:latest options: -uroot --device=/dev/bus/usb/001/002 ``` I would prefer to write a test for this fix, but I'm not very familiar with the project or the programming language. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2210

No description provided.

Rows
Columns

[PR #1957] [MERGED] fix: "Unknown server OS" for Docker container --device option #2210

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #1957] [MERGED] fix: "Unknown server OS" for Docker container `--device` option #2210