[PR #1941] [MERGED] fix: cmd support for windows #2201

New issue

Closed

opened 2026-03-01 21:54:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1941
Author: @ChristopherHX
Created: 8/1/2023
Status: ✅ Merged
Merged: 8/8/2023
Merged by: @mergify[bot]

Base: master ← Head: cmd-support

📝 Commits (3)

8bfc1d6 feat: cmd support for windows
9167924 Merge branch 'master' into cmd-support
22affb5 Merge branch 'master' into cmd-support

📊 Changes

5 files changed (+22 additions, -3 deletions)

View changed files

📝 pkg/container/host_environment.go (+5 -1)
📝 pkg/model/workflow.go (+1 -1)
📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_run.go (+6 -1)
➕ pkg/runner/testdata/windows-shell-cmd/push.yml (+9 -0)

📄 Description

The cmd seem to be not compatible with shellquote / golang argv handling. Also remove comspec from the shell template for cmd.

Related #1608

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1941 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 8/1/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cmd-support` --- ### 📝 Commits (3) - [`8bfc1d6`](https://github.com/nektos/act/commit/8bfc1d6f00cb4a6900277a8b2ec5c68609d5973b) feat: cmd support for windows - [`9167924`](https://github.com/nektos/act/commit/9167924605df1db154d7ae02d2e7858d0098ef1b) Merge branch 'master' into cmd-support - [`22affb5`](https://github.com/nektos/act/commit/22affb55ade87b2605aecb4350035f0e9c05bebd) Merge branch 'master' into cmd-support ### 📊 Changes **5 files changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/host_environment.go` (+5 -1) 📝 `pkg/model/workflow.go` (+1 -1) 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_run.go` (+6 -1) ➕ `pkg/runner/testdata/windows-shell-cmd/push.yml` (+9 -0) </details> ### 📄 Description The cmd seem to be not compatible with shellquote / golang argv handling. Also remove comspec from the shell template for cmd. Related #1608 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2201

No description provided.

Rows
Columns