[PR #1804] [MERGED] throw when invalid `uses` key is provided #2135

New issue

Closed

opened 2026-03-01 21:54:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1804
Author: @JoshMcCullough
Created: 5/13/2023
Status: ✅ Merged
Merged: 7/11/2023
Merged by: @cplee

Base: master ← Head: jsm/fix-workflow-jobtype

📝 Commits (10+)

e874540 throw if uses is invalid
79776a8 update JobType to return error
ab711ff Merge branch 'master' into jsm/fix-workflow-jobtype
5a95bfe lint
b8b3c8e put //nolint:dupl on wrong test
0060436 update error message to remove end punctuation
919982c lint
7d005c1 update remote job type check
921167b move if statement
bc33613 rm nolint:dupl ... we'll see how that goes

📊 Changes

4 files changed (+123 additions, -30 deletions)

View changed files

📝 pkg/model/workflow.go (+27 -9)
📝 pkg/model/workflow_test.go (+71 -10)
📝 pkg/runner/run_context.go (+18 -10)
📝 pkg/runner/runner.go (+7 -1)

📄 Description

Originally I thought the path checks were too specific, and the a reusable workflow didn't need to be stored under .github/workflows/. I believe I was confusing actions with workflows while reading the docs. So in the end, this PR ends up being simply to throw/exit in the case that an invalid uses is provided.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1804 **Author:** [@JoshMcCullough](https://github.com/JoshMcCullough) **Created:** 5/13/2023 **Status:** ✅ Merged **Merged:** 7/11/2023 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `jsm/fix-workflow-jobtype` --- ### 📝 Commits (10+) - [`e874540`](https://github.com/nektos/act/commit/e874540714e8beb236c001b5e9ea0791901e5572) throw if `uses` is invalid - [`79776a8`](https://github.com/nektos/act/commit/79776a8586350a5cbb8a74dd29beac0a1540e6ab) update JobType to return error - [`ab711ff`](https://github.com/nektos/act/commit/ab711ffc7468d398eb20bbc52c681754c2beda71) Merge branch 'master' into jsm/fix-workflow-jobtype - [`5a95bfe`](https://github.com/nektos/act/commit/5a95bfef0b7872e06ad7d156f4ff31a9c9294bbd) lint - [`b8b3c8e`](https://github.com/nektos/act/commit/b8b3c8ef3d0a989e0ac2f0ac82dc8aaa3b877ced) put //nolint:dupl on wrong test - [`0060436`](https://github.com/nektos/act/commit/0060436233eacd9f0234acf995c415d29c5025d8) update error message to remove end punctuation - [`919982c`](https://github.com/nektos/act/commit/919982c81f594825f44fa4559caef701005f0de8) lint - [`7d005c1`](https://github.com/nektos/act/commit/7d005c12cb496e39a64dcd7ed66f32dc7ddd56b2) update remote job type check - [`921167b`](https://github.com/nektos/act/commit/921167bc1622f04c715c4c1a56a3a1c2610f1774) move if statement - [`bc33613`](https://github.com/nektos/act/commit/bc336131911000a6704d41e8087f031c0ba36f91) rm nolint:dupl ... we'll see how that goes ### 📊 Changes **4 files changed** (+123 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+27 -9) 📝 `pkg/model/workflow_test.go` (+71 -10) 📝 `pkg/runner/run_context.go` (+18 -10) 📝 `pkg/runner/runner.go` (+7 -1) </details> ### 📄 Description Originally I thought the path checks were too specific, and the a reusable workflow didn't need to be stored under `.github/workflows/`. I believe I was confusing _actions_ with _workflows_ while reading the docs. So in the end, this PR ends up being simply to throw/exit in the case that an invalid `uses` is provided. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2135

No description provided.

Rows
Columns

[PR #1804] [MERGED] throw when invalid uses key is provided #2135

📋 Pull Request Information

📝 Commits (10+)

📊 Changes

📄 Description

[PR #1804] [MERGED] throw when invalid `uses` key is provided #2135