[PR #1783] [MERGED] fix: don't allow `-self-hosted` mode as container image #2126

New issue

Closed

opened 2026-03-01 21:54:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1783
Author: @ChristopherHX
Created: 5/1/2023
Status: ✅ Merged
Merged: 5/3/2023
Merged by: @mergify[bot]

Base: master ← Head: do-not-allow-self-hosted-as-image-name

📝 Commits (5)

e781db8 fix: don't allow -self-hosted mode as container image
f551ebd fix: jobcontainer in hostmode platform
cbdc240 Update run_context.go
3febaef Merge branch 'master' into do-not-allow-self-hosted-as-image-name
12dae2d Merge branch 'master' into do-not-allow-self-hosted-as-image-name

📊 Changes

1 file changed (+18 additions, -3 deletions)

View changed files

📝 pkg/runner/run_context.go (+18 -3)

📄 Description

Currently act will accept jobs like

container: -self-hosted

I suggest to to block this syntax and require to write -P freebsd=-self-hosted.

An empty container name will now use the platform image of the runs-on label, just like actions/runner

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1783 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 5/1/2023 **Status:** ✅ Merged **Merged:** 5/3/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `do-not-allow-self-hosted-as-image-name` --- ### 📝 Commits (5) - [`e781db8`](https://github.com/nektos/act/commit/e781db8317b2ab7cfaf8931b74a81217e2c6b5b8) fix: don't allow `-self-hosted` mode as container image - [`f551ebd`](https://github.com/nektos/act/commit/f551ebd670450c1e73ad06c3d64846415924103d) fix: jobcontainer in hostmode platform - [`cbdc240`](https://github.com/nektos/act/commit/cbdc24021d9142efff8029b57334077580d62b45) Update run_context.go - [`3febaef`](https://github.com/nektos/act/commit/3febaef0fc3b13a7ec3a3d9986930e46630a0dce) Merge branch 'master' into do-not-allow-self-hosted-as-image-name - [`12dae2d`](https://github.com/nektos/act/commit/12dae2d7e908f2e5105122f4c3c7eb16b8d2f887) Merge branch 'master' into do-not-allow-self-hosted-as-image-name ### 📊 Changes **1 file changed** (+18 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+18 -3) </details> ### 📄 Description Currently act will accept jobs like ```yaml container: -self-hosted ``` I suggest to to block this syntax and require to write `-P freebsd=-self-hosted`. _An empty container name will now use the platform image of the runs-on label, just like actions/runner_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2126

No description provided.

Rows
Columns

[PR #1783] [MERGED] fix: don't allow -self-hosted mode as container image #2126

📋 Pull Request Information

📝 Commits (5)

📊 Changes

📄 Description

[PR #1783] [MERGED] fix: don't allow `-self-hosted` mode as container image #2126