starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 09:25:54 +03:00

[PR #1705] [MERGED] Avoid using `log.Fatal` in `pkg/*` #2081

New issue

Closed

opened 2026-03-01 21:53:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1705
Author: @wolfogre
Created: 3/28/2023
Status: ✅ Merged
Merged: 4/18/2023
Merged by: @mergify[bot]

Base: master ← Head: bugfix/avoid_log_fatal

📝 Commits (10+)

6599803 fix: common
0fb5327 fix: in runner
02ae778 fix: decodeNode
6a2a1b7 fix: GetMatrixes
9ab71eb Revert "fix: common"
fc50955 fix: GetOutboundIP
7b92a8e test: fix cases
a2413a0 Merge branch 'master' into bugfix/avoid_log_fatal
cc20176 Merge branch 'master' into bugfix/avoid_log_fatal
9ffc5a6 Merge branch 'master' into bugfix/avoid_log_fatal

📊 Changes

4 files changed (+53 additions, -32 deletions)

View changed files

📝 pkg/model/workflow.go (+33 -25)
📝 pkg/model/workflow_test.go (+12 -4)
📝 pkg/runner/run_context.go (+2 -2)
📝 pkg/runner/runner.go (+6 -1)

📄 Description

Although act is a command line tool, it is also a bad idea to use log.Fatal in packages.

To be clear, only packages which are used as libraries. It's fine to use fatal in cmd.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1705 **Author:** [@wolfogre](https://github.com/wolfogre) **Created:** 3/28/2023 **Status:** ✅ Merged **Merged:** 4/18/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/avoid_log_fatal` --- ### 📝 Commits (10+) - [`6599803`](https://github.com/nektos/act/commit/6599803b6ae3b7adc168ef41b4afd4d89fc22f34) fix: common - [`0fb5327`](https://github.com/nektos/act/commit/0fb53273e55e4b347af62b05549e6fa1934255d5) fix: in runner - [`02ae778`](https://github.com/nektos/act/commit/02ae778e409691b02ea7e0529db1bc0bc1aaeb68) fix: decodeNode - [`6a2a1b7`](https://github.com/nektos/act/commit/6a2a1b7c6916fab72040b73abc23d835300c3517) fix: GetMatrixes - [`9ab71eb`](https://github.com/nektos/act/commit/9ab71eb01fce4d2b55e64651e7177307d6f4d84a) Revert "fix: common" - [`fc50955`](https://github.com/nektos/act/commit/fc509553b6a482bbf7b1b59ae059c40bef7b4ac3) fix: GetOutboundIP - [`7b92a8e`](https://github.com/nektos/act/commit/7b92a8e9d2137229b331a63018e716462fb92488) test: fix cases - [`a2413a0`](https://github.com/nektos/act/commit/a2413a09e2e4058f62574b6fc2fa1a8914725b57) Merge branch 'master' into bugfix/avoid_log_fatal - [`cc20176`](https://github.com/nektos/act/commit/cc20176089d59ee9a4523f59eb93b7de66774744) Merge branch 'master' into bugfix/avoid_log_fatal - [`9ffc5a6`](https://github.com/nektos/act/commit/9ffc5a6cb4438297428e3cc2a2997b57c17a5941) Merge branch 'master' into bugfix/avoid_log_fatal ### 📊 Changes **4 files changed** (+53 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+33 -25) 📝 `pkg/model/workflow_test.go` (+12 -4) 📝 `pkg/runner/run_context.go` (+2 -2) 📝 `pkg/runner/runner.go` (+6 -1) </details> ### 📄 Description Although act is a command line tool, it is also a bad idea to use `log.Fatal` in packages. To be clear, only packages which are used as libraries. It's fine to use fatal in `cmd`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:55 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:42 +03:00

[PR #2089] [MERGED] Don't set GITHUB_TOKEN env variable #2265

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2081

No description provided.

Rows
Columns

[PR #1705] [MERGED] Avoid using log.Fatal in pkg/* #2081

📋 Pull Request Information

📝 Commits (10+)

📊 Changes

📄 Description

[PR #1705] [MERGED] Avoid using `log.Fatal` in `pkg/*` #2081