[PR #1660] [MERGED] fix: crash if the id tool fails to run in the container #2056

New issue

Closed

opened 2026-03-01 21:53:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1660
Author: @ChristopherHX
Created: 3/2/2023
Status: ✅ Merged
Merged: 3/8/2023
Merged by: @mergify[bot]

Base: master ← Head: fix-crash-readid

📝 Commits (4)

77ae92d fix: crash if the id tool fails to run in the container
93df0c5 remove import
c84aeb6 Add check in a test that tryReadID doesn't fail
3b05246 Merge branch 'master' into fix-crash-readid

📊 Changes

2 files changed (+16 additions, -1 deletions)

View changed files

📝 pkg/container/docker_run.go (+1 -1)
📝 pkg/runner/testdata/remote-action-js-node-user/push.yml (+15 -0)

📄 Description

Reported here: https://gitea.com/gitea/act_runner/issues/32#issuecomment-732256

Also adds a test that the test case does actually run via user node and can write to the GITHUB_OUTPUT file command.

Commit Message

{{title}} ({{number}})

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1660 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 3/2/2023 **Status:** ✅ Merged **Merged:** 3/8/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-crash-readid` --- ### 📝 Commits (4) - [`77ae92d`](https://github.com/nektos/act/commit/77ae92d9ab0acbab70f4be08c13b9626b0138f81) fix: crash if the id tool fails to run in the container - [`93df0c5`](https://github.com/nektos/act/commit/93df0c539e32399b4bec9ab529d52ab2d82b5126) remove import - [`c84aeb6`](https://github.com/nektos/act/commit/c84aeb6d1ac174f69e95c8b29e76b7c83a7c6f61) Add check in a test that tryReadID doesn't fail - [`3b05246`](https://github.com/nektos/act/commit/3b05246c1d6b4c269e02010f0dd5ed9aaf8700e8) Merge branch 'master' into fix-crash-readid ### 📊 Changes **2 files changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+1 -1) 📝 `pkg/runner/testdata/remote-action-js-node-user/push.yml` (+15 -0) </details> ### 📄 Description Reported here: https://gitea.com/gitea/act_runner/issues/32#issuecomment-732256 Also adds a test that the test case does actually run via user node and can write to the GITHUB_OUTPUT file command. ## Commit Message {{title}} ({{number}}) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:49 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:39 +03:00

[PR #2061] fix: compute ref and ref_name prioritising HEAD pointer if tag is not set #2251

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2056

No description provided.

Rows
Columns