[PR #1629] [MERGED] fix: don't use os.Environ to override env #2041

New issue

Closed

opened 2026-03-01 21:53:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1629
Author: @wolfogre
Created: 2/15/2023
Status: ✅ Merged
Merged: 2/16/2023
Merged by: @mergify[bot]

Base: master ← Head: bugfix/dont_override_env

📝 Commits (1)

e92b6e0 fix: don't override env

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 pkg/runner/run_context.go (+5 -3)

📄 Description

If the env has been set in the yaml file, we shouldn't override it with os env.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1629 **Author:** [@wolfogre](https://github.com/wolfogre) **Created:** 2/15/2023 **Status:** ✅ Merged **Merged:** 2/16/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/dont_override_env` --- ### 📝 Commits (1) - [`e92b6e0`](https://github.com/nektos/act/commit/e92b6e0fab4c6ecd3b52b002ca9b67bfb0bfa44a) fix: don't override env ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+5 -3) </details> ### 📄 Description If the env has been set in the yaml file, we shouldn't override it with os env. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:45 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:37 +03:00

[PR #2041] [CLOSED] Ignore git env when running as HostEnvironment #2244

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2041

No description provided.

Rows
Columns