[PR #1560] [MERGED] fix: allow override of artifact server bind address #2002

Closed
opened 2026-03-01 21:53:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1560
Author: @isometry
Created: 1/13/2023
Status: Merged
Merged: 1/16/2023
Merged by: @mergify[bot]

Base: masterHead: bugfix/artifact-server-addr


📝 Commits (2)

  • b23c454 fix: allow override of artifact server bind address
  • d71c045 Merge branch 'master' into bugfix/artifact-server-addr

📊 Changes

7 files changed (+18 additions, -12 deletions)

View changed files

📝 README.md (+2 -1)
📝 cmd/input.go (+1 -0)
📝 cmd/root.go (+4 -2)
📝 pkg/artifacts/server.go (+3 -4)
📝 pkg/artifacts/server_test.go (+6 -4)
📝 pkg/runner/run_context.go (+1 -1)
📝 pkg/runner/runner.go (+1 -0)

📄 Description

  • Prior to this change, the artifact server always binds to the detected "outbound IP", breaks functionality when that IP is unroutable. For example, Zscaler assigns the host a local CGNAT address, 100.64.0.1, which is unreachable from Docker Desktop.
  • Add the --artifact-server-addr flag to allow override of the address to which the artifact server binds, defaulting to the existing behaviour.

Fixes #1559


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1560 **Author:** [@isometry](https://github.com/isometry) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `bugfix/artifact-server-addr` --- ### 📝 Commits (2) - [`b23c454`](https://github.com/nektos/act/commit/b23c454578375450479ea75b2e30de56a30ebfa6) fix: allow override of artifact server bind address - [`d71c045`](https://github.com/nektos/act/commit/d71c0453505e05b5c352d7d56975fa581bc0a3d5) Merge branch 'master' into bugfix/artifact-server-addr ### 📊 Changes **7 files changed** (+18 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -1) 📝 `cmd/input.go` (+1 -0) 📝 `cmd/root.go` (+4 -2) 📝 `pkg/artifacts/server.go` (+3 -4) 📝 `pkg/artifacts/server_test.go` (+6 -4) 📝 `pkg/runner/run_context.go` (+1 -1) 📝 `pkg/runner/runner.go` (+1 -0) </details> ### 📄 Description * Prior to this change, the artifact server always binds to the detected "outbound IP", breaks functionality when that IP is unroutable. For example, Zscaler assigns the host a local CGNAT address, 100.64.0.1, which is unreachable from Docker Desktop. * Add the `--artifact-server-addr` flag to allow override of the address to which the artifact server binds, defaulting to the existing behaviour. Fixes #1559 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#2002
No description provided.