[PR #1519] [MERGED] fix: preserve job result state in case of failure #1982

New issue

Closed

opened 2026-03-01 21:53:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1519
Author: @KnisterPeter
Created: 12/19/2022
Status: ✅ Merged
Merged: 1/10/2023
Merged by: @mergify[bot]

Base: master ← Head: preserve-job-result

📝 Commits (3)

bc1d7df fix: preserve job result state in case of failure
43f582d test: remove continue-on-error on job level
78394a9 Merge branch 'master' into preserve-job-result

📊 Changes

3 files changed (+31 additions, -2 deletions)

View changed files

📝 pkg/runner/job_executor.go (+14 -2)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/matrix-exitcode/push.yml (+16 -0)

📄 Description

There is just one job field for the job result. This is also true for
matrix jobs. We need to preserve the failure state of a job to
have the whole job failing in case of one permuation of the matrix failed.

Closes #1518

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1519 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 12/19/2022 **Status:** ✅ Merged **Merged:** 1/10/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `preserve-job-result` --- ### 📝 Commits (3) - [`bc1d7df`](https://github.com/nektos/act/commit/bc1d7df000689bda428d38397b832d2a6f6b5215) fix: preserve job result state in case of failure - [`43f582d`](https://github.com/nektos/act/commit/43f582de7a1c6873cc97cd99aa856ed6163d1b55) test: remove continue-on-error on job level - [`78394a9`](https://github.com/nektos/act/commit/78394a91cc05b8b956eb6a8cef35f00a37496f9c) Merge branch 'master' into preserve-job-result ### 📊 Changes **3 files changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+14 -2) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/matrix-exitcode/push.yml` (+16 -0) </details> ### 📄 Description There is just one job field for the job result. This is also true for matrix jobs. We need to preserve the failure state of a job to have the whole job failing in case of one permuation of the matrix failed. Closes #1518 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:31 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1982

No description provided.

Rows
Columns