[PR #1514] [MERGED] revert: deprecation of containerArchitecture #1980

Closed
opened 2026-03-01 21:53:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1514
Author: @ChristopherHX
Created: 12/18/2022
Status: Merged
Merged: 12/19/2022
Merged by: @mergify[bot]

Base: masterHead: revert-deprecation-containerArchitecture


📝 Commits (3)

  • 09dd1d5 fix: ci snaphot job
  • 6b0883c revert: deprecation of containerArchitecture
  • 6b8ae87 Merge branch 'master' into revert-deprecation-containerArchitecture

📊 Changes

2 files changed (+1 additions, -4 deletions)

View changed files

📝 .github/actions/choco/Dockerfile (+1 -1)
📝 cmd/root.go (+0 -3)

📄 Description

This option isn't part of parsed docker cli flags of act.

Nobody protected me doing nonsense, I really expected that the --platform has been parsed.

Even if this flag has been parsed by docker options logic, this flag wouldn't be applied to docker_pull and other parts of act


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1514 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/18/2022 **Status:** ✅ Merged **Merged:** 12/19/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `revert-deprecation-containerArchitecture` --- ### 📝 Commits (3) - [`09dd1d5`](https://github.com/nektos/act/commit/09dd1d5adc667d181e0a7dd98825063965b9d373) fix: ci snaphot job - [`6b0883c`](https://github.com/nektos/act/commit/6b0883c467cef748f487d37c877fdc94b9b50e99) revert: deprecation of containerArchitecture - [`6b8ae87`](https://github.com/nektos/act/commit/6b8ae87b288955ff79d997f897b35f01dfd88c77) Merge branch 'master' into revert-deprecation-containerArchitecture ### 📊 Changes **2 files changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/choco/Dockerfile` (+1 -1) 📝 `cmd/root.go` (+0 -3) </details> ### 📄 Description This option isn't part of parsed docker cli flags of act. _Nobody protected me doing nonsense, I really expected that the `--platform` has been parsed._ _Even if this flag has been parsed by docker options logic, this flag wouldn't be applied to docker_pull and other parts of act_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1980
No description provided.