[PR #1503] [MERGED] refactor: GITHUB_ENV command / remove env.PATH #1973

New issue

Closed

opened 2026-03-01 21:53:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1503
Author: @ChristopherHX
Created: 12/11/2022
Status: ✅ Merged
Merged: 2/4/2023
Merged by: @mergify[bot]

Base: master ← Head: fix-GITHUB_ENV-path-handling

📝 Commits (10+)

65b339a fix: GITHUB_ENV / PATH handling
9fe22f7 apply workaround
f696467 add ctx to ApplyExtraPath
7de02e2 Merge branch 'master' into fix-GITHUB_ENV-path-handling
a8e7aba Merge branch 'master' into fix-GITHUB_ENV-path-handling
8bde9c5 Merge branch 'master' into fix-GITHUB_ENV-path-handling
9c69677 Merge branch 'master' into fix-GITHUB_ENV-path-handling
7df1125 fix: Do not leak step env in composite
3a87cce Merge branch 'master' into fix-GITHUB_ENV-path-handling
b44d6e3 add more tests

📊 Changes

18 files changed (+176 additions, -64 deletions)

View changed files

📝 pkg/runner/action.go (+3 -3)
📝 pkg/runner/action_composite.go (+9 -0)
📝 pkg/runner/command.go (+8 -2)
📝 pkg/runner/run_context.go (+13 -5)
📝 pkg/runner/runner_test.go (+7 -1)
📝 pkg/runner/step.go (+22 -17)
📝 pkg/runner/step_action_local_test.go (+6 -10)
📝 pkg/runner/step_action_remote_test.go (+8 -8)
📝 pkg/runner/step_docker_test.go (+4 -8)
📝 pkg/runner/step_run.go (+1 -1)
📝 pkg/runner/step_run_test.go (+1 -5)
📝 pkg/runner/step_test.go (+0 -4)
➕ pkg/runner/testdata/GITHUB_ENV-use-in-env-ctx/push.yml (+27 -0)
📝 pkg/runner/testdata/do-not-leak-step-env-in-composite/push.yml (+1 -0)
➕ pkg/runner/testdata/docker-action-custom-path/push.yml (+12 -0)
➕ pkg/runner/testdata/remote-action-js-node-user/push.yml (+15 -0)
➕ pkg/runner/testdata/set-env-new-env-file-per-step/push.yml (+15 -0)
➕ pkg/runner/testdata/set-env-step-env-override/push.yml (+24 -0)

📄 Description

I'm potentially breaking non standard act specfic workflows

With this change are all file commands in a single place again.

Closes #1384
Closes #1421

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1503 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/11/2022 **Status:** ✅ Merged **Merged:** 2/4/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-GITHUB_ENV-path-handling` --- ### 📝 Commits (10+) - [`65b339a`](https://github.com/nektos/act/commit/65b339a86258934728e55978f98ca63922598bd3) fix: GITHUB_ENV / PATH handling - [`9fe22f7`](https://github.com/nektos/act/commit/9fe22f73eb15c3a33f9712867dffd6118b8a01c8) apply workaround - [`f696467`](https://github.com/nektos/act/commit/f69646740fb33770d0c5ca6b51299ad4aa8b3bd8) add ctx to ApplyExtraPath - [`7de02e2`](https://github.com/nektos/act/commit/7de02e27e287de6d6c2ee31c3edd700602ebf0a4) Merge branch 'master' into fix-GITHUB_ENV-path-handling - [`a8e7aba`](https://github.com/nektos/act/commit/a8e7aba71b58e50c4171a33592ada68b0b2a344a) Merge branch 'master' into fix-GITHUB_ENV-path-handling - [`8bde9c5`](https://github.com/nektos/act/commit/8bde9c5d049799fd2ca5df4d6b310ecf6984f6d9) Merge branch 'master' into fix-GITHUB_ENV-path-handling - [`9c69677`](https://github.com/nektos/act/commit/9c696773d6b7396c3b97b0acae16cef36972cffa) Merge branch 'master' into fix-GITHUB_ENV-path-handling - [`7df1125`](https://github.com/nektos/act/commit/7df11256c4a0d0cc05989b727f8f516d6b1c8bf9) fix: Do not leak step env in composite - [`3a87cce`](https://github.com/nektos/act/commit/3a87cce73c7f10c7f9e89a9d95039f501eccf8ee) Merge branch 'master' into fix-GITHUB_ENV-path-handling - [`b44d6e3`](https://github.com/nektos/act/commit/b44d6e3a705fdc1e46ef516b5b309fcb79604697) add more tests ### 📊 Changes **18 files changed** (+176 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action.go` (+3 -3) 📝 `pkg/runner/action_composite.go` (+9 -0) 📝 `pkg/runner/command.go` (+8 -2) 📝 `pkg/runner/run_context.go` (+13 -5) 📝 `pkg/runner/runner_test.go` (+7 -1) 📝 `pkg/runner/step.go` (+22 -17) 📝 `pkg/runner/step_action_local_test.go` (+6 -10) 📝 `pkg/runner/step_action_remote_test.go` (+8 -8) 📝 `pkg/runner/step_docker_test.go` (+4 -8) 📝 `pkg/runner/step_run.go` (+1 -1) 📝 `pkg/runner/step_run_test.go` (+1 -5) 📝 `pkg/runner/step_test.go` (+0 -4) ➕ `pkg/runner/testdata/GITHUB_ENV-use-in-env-ctx/push.yml` (+27 -0) 📝 `pkg/runner/testdata/do-not-leak-step-env-in-composite/push.yml` (+1 -0) ➕ `pkg/runner/testdata/docker-action-custom-path/push.yml` (+12 -0) ➕ `pkg/runner/testdata/remote-action-js-node-user/push.yml` (+15 -0) ➕ `pkg/runner/testdata/set-env-new-env-file-per-step/push.yml` (+15 -0) ➕ `pkg/runner/testdata/set-env-step-env-override/push.yml` (+24 -0) </details> ### 📄 Description I'm potentially breaking non standard act specfic workflows With this change are all file commands in a single place again. Closes #1384 Closes #1421 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:29 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:29 +03:00

[PR #1973] [MERGED] Mention act user guide in act #2217

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1973

No description provided.

Rows
Columns