[PR #1501] [MERGED] refactor: remove docker image list reference filter #1971

New issue

Closed

opened 2026-03-01 21:53:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1501
Author: @ChristopherHX
Created: 12/10/2022
Status: ✅ Merged
Merged: 1/13/2023
Merged by: @mergify[bot]

Base: master ← Head: remove-reference-filter

📝 Commits (7)

c0503a1 refactor: remove docker reference filter
d90ba46 make it work
76fe17f solve logic failure
03ed267 Another mistake
f1f7748 another one
623b6b2 revert signature of ImageExistsLocally
9c9a6c6 Merge branch 'master' into remove-reference-filter

📊 Changes

1 file changed (+18 additions, -49 deletions)

View changed files

📝 pkg/container/docker_images.go (+18 -49)

📄 Description

~~Should I preserve the public ImageExistsLocally signature and make a private helper function?~~, reverted the new return value.

This uses docker inspect and remove docker list.
You cannot have multiple images of the same name+tag, regardless of platform metadata

Fixes https://github.com/nektos/act/issues/1390

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1501 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/10/2022 **Status:** ✅ Merged **Merged:** 1/13/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `remove-reference-filter` --- ### 📝 Commits (7) - [`c0503a1`](https://github.com/nektos/act/commit/c0503a1f0727fd31c3e7c2e2f3bb5c0cf4562921) refactor: remove docker reference filter - [`d90ba46`](https://github.com/nektos/act/commit/d90ba468271569e7f3ea8f6fc1e443604b46f494) make it work - [`76fe17f`](https://github.com/nektos/act/commit/76fe17f4ccc01e91848594560b21c4f6482a6945) solve logic failure - [`03ed267`](https://github.com/nektos/act/commit/03ed267c1e955654bc31776b511b2ed2b8a7af07) Another mistake - [`f1f7748`](https://github.com/nektos/act/commit/f1f7748cf4af558f2f76d7e54bdbb3837bb27595) another one - [`623b6b2`](https://github.com/nektos/act/commit/623b6b2374f700c0e706af082103316c60f98271) revert signature of ImageExistsLocally - [`9c9a6c6`](https://github.com/nektos/act/commit/9c9a6c63c5f28c8110ac8e1ab10d93c769968fab) Merge branch 'master' into remove-reference-filter ### 📊 Changes **1 file changed** (+18 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_images.go` (+18 -49) </details> ### 📄 Description ~_Should I preserve the public ImageExistsLocally signature and make a private helper function?_~, reverted the new return value. This uses docker inspect and remove docker list. You cannot have multiple images of the same name+tag, regardless of platform metadata Fixes https://github.com/nektos/act/issues/1390 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1971

No description provided.

Rows
Columns