[PR #1476] [MERGED] Pass LANG=C.UTF-8 to environment #1965

Closed
opened 2026-03-01 21:53:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1476
Author: @bric3
Created: 11/28/2022
Status: Merged
Merged: 12/6/2022
Merged by: @mergify[bot]

Base: masterHead: pass-lang-c-utf8


📝 Commits (3)

  • 7cb3dde fix: pass LANG=C.UTF-8 to environment
  • c34f12a fix: pass LANG=C.UTF-8 to environment in container only
  • 3b663ac Merge branch 'master' into pass-lang-c-utf8

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 pkg/runner/run_context.go (+1 -0)

📄 Description

In order to use act with workflows where any tools, like build tools, depends on the locale being UTF-8, one must pass via command line via the --env option.

However the Github Actions runner already passes LANG=C.UTF-8 by default, which makes the need to explicitly pass this variable via command line un-intuitive.

The PR here aims to make act pass that environment variable by default.

Fixes: #1308
Possibly #639


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1476 **Author:** [@bric3](https://github.com/bric3) **Created:** 11/28/2022 **Status:** ✅ Merged **Merged:** 12/6/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `pass-lang-c-utf8` --- ### 📝 Commits (3) - [`7cb3dde`](https://github.com/nektos/act/commit/7cb3dde28f5a630631f2d200cd0e963c2eb05075) fix: pass LANG=C.UTF-8 to environment - [`c34f12a`](https://github.com/nektos/act/commit/c34f12a20a2f5bee89066f24dde3ff9fa6f9bbcf) fix: pass LANG=C.UTF-8 to environment in container only - [`3b663ac`](https://github.com/nektos/act/commit/3b663acfc12c1a36da0bcfd9195007d20a371b55) Merge branch 'master' into pass-lang-c-utf8 ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+1 -0) </details> ### 📄 Description In order to use `act` with workflows where any tools, like build tools, depends on the locale being `UTF-8`, one must pass via command line via the `--env` option. However the Github Actions runner already passes `LANG=C.UTF-8` by default, which makes the need to explicitly pass this variable via command line un-intuitive. The PR here aims to make `act` pass that environment variable by default. Fixes: #1308 Possibly #639 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1965
No description provided.