[PR #1463] [MERGED] refactor: move autoremove into the jobexecutor #1959

New issue

Closed

opened 2026-03-01 21:53:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1463
Author: @ChristopherHX
Created: 11/24/2022
Status: ✅ Merged
Merged: 12/6/2022
Merged by: @mergify[bot]

Base: master ← Head: refactor-autoremove

📝 Commits (6)

3e7a9f3 refactor: move autoremove into the jobexecutor
47d1998 reduce complexity
aef863f remove linter exception
4e52c3e reduce cyclic complexity
3960dee fix: always allow 1 min for stopping and removing the runner, even if we were cancelled
c35950b Merge branch 'master' into refactor-autoremove

📊 Changes

2 files changed (+23 additions, -41 deletions)

View changed files

📝 pkg/runner/job_executor.go (+21 -14)
📝 pkg/runner/runner.go (+2 -27)

📄 Description

breaking: docker container are removed after job exit

In github-act-runner I directly instantiate the RunContext, but I also want to make use of autoremove due to randomized job container name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1463 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 11/24/2022 **Status:** ✅ Merged **Merged:** 12/6/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor-autoremove` --- ### 📝 Commits (6) - [`3e7a9f3`](https://github.com/nektos/act/commit/3e7a9f30de8b3dd305a31f2d0ee1a424a56197cb) refactor: move autoremove into the jobexecutor - [`47d1998`](https://github.com/nektos/act/commit/47d199849309bb8c34217e00631309196086a432) reduce complexity - [`aef863f`](https://github.com/nektos/act/commit/aef863fc867270dac11d738988fdf7efddddc7da) remove linter exception - [`4e52c3e`](https://github.com/nektos/act/commit/4e52c3eff4660bdfd0733b860a70da450ea7d494) reduce cyclic complexity - [`3960dee`](https://github.com/nektos/act/commit/3960deee18fbd91f0b46847ab547de00ff18fcba) fix: always allow 1 min for stopping and removing the runner, even if we were cancelled - [`c35950b`](https://github.com/nektos/act/commit/c35950b81e99dea67ab8bef658ba84ce3e5a9999) Merge branch 'master' into refactor-autoremove ### 📊 Changes **2 files changed** (+23 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+21 -14) 📝 `pkg/runner/runner.go` (+2 -27) </details> ### 📄 Description breaking: docker container are removed after job exit In github-act-runner I directly instantiate the RunContext, but I also want to make use of autoremove due to randomized job container name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:28 +03:00

[PR #1959] [MERGED] ci: change winget job runner to ubuntu-latest #2211

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1959

No description provided.

Rows
Columns