[PR #1458] [MERGED] fix: step env is unavailable in with property expr #1956

New issue

Closed

opened 2026-03-01 21:53:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1458
Author: @ChristopherHX
Created: 11/23/2022
Status: ✅ Merged
Merged: 12/6/2022
Merged by: @mergify[bot]

Base: master ← Head: fix-step-env-in-with-property

📝 Commits (4)

3e72103 fix: step env is unavailable in with property expr
a843e67 don't run the test on windows
354f545 fix: composite action add missing shell
d44f6b4 Merge branch 'master' into fix-step-env-in-with-property

📊 Changes

5 files changed (+40 additions, -2 deletions)

View changed files

📝 pkg/runner/expression.go (+5 -1)
📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step.go (+11 -1)
➕ pkg/runner/testdata/inputs-via-env-context/action.yml (+8 -0)
➕ pkg/runner/testdata/inputs-via-env-context/push.yml (+15 -0)

📄 Description

Weird inputs and env are both evaluated in the env context. This change delays the evaluation of INPUT_ env vars and makes the step env available. This feels like a hack to make act do what we expect.

Related to #1421, but more bugs are mentioned there

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1458 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 11/23/2022 **Status:** ✅ Merged **Merged:** 12/6/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-step-env-in-with-property` --- ### 📝 Commits (4) - [`3e72103`](https://github.com/nektos/act/commit/3e72103266de50490c9974a1108cded8c785a90b) fix: step env is unavailable in with property expr - [`a843e67`](https://github.com/nektos/act/commit/a843e67d9d89fd346fddb9f2e3d2d5465e6b271d) don't run the test on windows - [`354f545`](https://github.com/nektos/act/commit/354f545c7a21993d9e2fdfca3dd0c5a1e6e2e9cf) fix: composite action add missing shell - [`d44f6b4`](https://github.com/nektos/act/commit/d44f6b4aeb45128716d9abad761c50743c2f2a28) Merge branch 'master' into fix-step-env-in-with-property ### 📊 Changes **5 files changed** (+40 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+5 -1) 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step.go` (+11 -1) ➕ `pkg/runner/testdata/inputs-via-env-context/action.yml` (+8 -0) ➕ `pkg/runner/testdata/inputs-via-env-context/push.yml` (+15 -0) </details> ### 📄 Description Weird inputs and env are both evaluated in the env context. This change delays the evaluation of INPUT_ env vars and makes the step env available. This feels like a hack to make act do what we expect. Related to #1421, but more bugs are mentioned there --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:24 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1956

No description provided.

Rows
Columns