[PR #1457] [MERGED] refactor: share UpdateFromEnv logic #1954

New issue

Closed

opened 2026-03-01 21:53:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1457
Author: @ChristopherHX
Created: 11/23/2022
Status: ✅ Merged
Merged: 12/6/2022
Merged by: @mergify[bot]

Base: master ← Head: share-env-file-parser-container-host

📝 Commits (5)

afe4e90 refactor: share UpdateFromEnv logic
8499c84 Add test for GITHUB_OUTPUT
f9f275e Add GITHUB_STATE test
033b4f6 Add test for the old broken parser
fa8753e Merge branch 'master' into share-env-file-parser-container-host

📊 Changes

7 files changed (+201 additions, -99 deletions)

View changed files

📝 pkg/container/docker_run.go (+1 -54)
📝 pkg/container/host_environment.go (+1 -45)
➕ pkg/container/parse_env_file.go (+60 -0)
📝 pkg/runner/runner_test.go (+3 -0)
➕ pkg/runner/testdata/GITHUB_STATE/push.yml (+22 -0)
➕ pkg/runner/testdata/environment-files-parser-bug/push.yaml (+13 -0)
➕ pkg/runner/testdata/environment-files/push.yaml (+101 -0)

📄 Description

No public interface has been changed.

TODO

Add tests for bugs of the old docker_run impl.
Add tests for GITHUB_OUTPUT / GITHUB_STATE

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1457 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 11/23/2022 **Status:** ✅ Merged **Merged:** 12/6/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `share-env-file-parser-container-host` --- ### 📝 Commits (5) - [`afe4e90`](https://github.com/nektos/act/commit/afe4e90236ce03c86ef97a67c88e572ff6ce51a2) refactor: share UpdateFromEnv logic - [`8499c84`](https://github.com/nektos/act/commit/8499c842c5b5c6de827dd7a4b859e3559fedc4ec) Add test for GITHUB_OUTPUT - [`f9f275e`](https://github.com/nektos/act/commit/f9f275e847400596cdb484d01c56c3b081b73af9) Add GITHUB_STATE test - [`033b4f6`](https://github.com/nektos/act/commit/033b4f6dbf5c74d2772d91fb9fa6475e79a1ce66) Add test for the old broken parser - [`fa8753e`](https://github.com/nektos/act/commit/fa8753ea5417cdcb559d1fe085a130025ba70677) Merge branch 'master' into share-env-file-parser-container-host ### 📊 Changes **7 files changed** (+201 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+1 -54) 📝 `pkg/container/host_environment.go` (+1 -45) ➕ `pkg/container/parse_env_file.go` (+60 -0) 📝 `pkg/runner/runner_test.go` (+3 -0) ➕ `pkg/runner/testdata/GITHUB_STATE/push.yml` (+22 -0) ➕ `pkg/runner/testdata/environment-files-parser-bug/push.yaml` (+13 -0) ➕ `pkg/runner/testdata/environment-files/push.yaml` (+101 -0) </details> ### 📄 Description No public interface has been changed. TODO - [x] Add tests for bugs of the old docker_run impl. - [x] Add tests for GITHUB_OUTPUT / GITHUB_STATE --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:24 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:27 +03:00

[PR #1954] [MERGED] feat: cli option to enable the new action cache #2207

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1954

No description provided.

Rows
Columns