[PR #1432] [MERGED] fix: nil pointer access ( workflow_dispatch ) #1946

Closed
opened 2026-03-01 21:53:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1432
Author: @ChristopherHX
Created: 11/9/2022
Status: Merged
Merged: 11/10/2022
Merged by: @mergify[bot]

Base: masterHead: ChristopherHX-patch-1


📝 Commits (7)

📊 Changes

5 files changed (+50 additions, -9 deletions)

View changed files

📝 pkg/runner/expression.go (+11 -9)
📝 pkg/runner/runner_test.go (+3 -0)
pkg/runner/testdata/workflow_dispatch-scalar-composite-action/workflow_dispatch.yml (+17 -0)
pkg/runner/testdata/workflow_dispatch-scalar/workflow_dispatch.yml (+9 -0)
pkg/runner/testdata/workflow_dispatch_no_inputs_mapping/workflow_dispatch.yml (+10 -0)

📄 Description

Reason for this change
WorkflowDispatchConfig can return nil and the inputs property can also be nil see bug report.
This happens for example in composite actions.

  • Add test

Closes #1430

Commit Message

{{title}}


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1432 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 11/9/2022 **Status:** ✅ Merged **Merged:** 11/10/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `ChristopherHX-patch-1` --- ### 📝 Commits (7) - [`89a14ad`](https://github.com/nektos/act/commit/89a14adf73f413e7c5fded0b44e0b34f9193829d) Update expression.go - [`3bcd039`](https://github.com/nektos/act/commit/3bcd0392a86d92586f49b20c44fa5b89adbafbe6) [no ci] - [`9985d70`](https://github.com/nektos/act/commit/9985d70074a196654ddef84b020994fc1f47afce) [no ci] - [`105d24d`](https://github.com/nektos/act/commit/105d24dd9cd46e75237e52097b79a559c781185d) [no ci] - [`2741ec2`](https://github.com/nektos/act/commit/2741ec2c5bcea55d7d16c2d2cc669fd8321e0a8c) [no ci] - [`6e6d5f8`](https://github.com/nektos/act/commit/6e6d5f8608972c21741e96e84e0ab31129446daa) [no ci] - [`42c2406`](https://github.com/nektos/act/commit/42c2406d9d9e9ec79c88f32c0db98b9df5c51e46) Update runner_test.go ### 📊 Changes **5 files changed** (+50 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+11 -9) 📝 `pkg/runner/runner_test.go` (+3 -0) ➕ `pkg/runner/testdata/workflow_dispatch-scalar-composite-action/workflow_dispatch.yml` (+17 -0) ➕ `pkg/runner/testdata/workflow_dispatch-scalar/workflow_dispatch.yml` (+9 -0) ➕ `pkg/runner/testdata/workflow_dispatch_no_inputs_mapping/workflow_dispatch.yml` (+10 -0) </details> ### 📄 Description Reason for this change WorkflowDispatchConfig can return nil and the inputs property can also be nil see bug report. This happens for example in composite actions. - [x] Add test Closes #1430 ## Commit Message {{title}} --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:21 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1946
No description provided.