[PR #1375] [MERGED] test: add test for networking setup in act #1912

New issue

Closed

opened 2026-03-01 21:53:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1375
Author: @KnisterPeter
Created: 10/7/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @mergify[bot]

Base: master ← Head: add-networking-test

📝 Commits (4)

ab5725f test: add test for networking setup in act
7ef26df fix: only merge existing container options
ddea957 refactor: split config merging into own function
b60da5a Merge branch 'master' into add-networking-test

📊 Changes

3 files changed (+63 additions, -30 deletions)

View changed files

📝 pkg/container/docker_run.go (+48 -30)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/networking/push.yml (+14 -0)

📄 Description

This test makes sure that the hostname inside of act is resolvable.
This will prevent regressions in the network setup (see #1351, #1022)

Act need to be started with docker network mode host by default. This was changed recently, leading to networking changes. That do break the previous (and expected) behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1375 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 10/7/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `add-networking-test` --- ### 📝 Commits (4) - [`ab5725f`](https://github.com/nektos/act/commit/ab5725fd1398977f915c54b629886d06d75b5083) test: add test for networking setup in act - [`7ef26df`](https://github.com/nektos/act/commit/7ef26df62d8f4770027ed2b25c1648db7e6a0a34) fix: only merge existing container options - [`ddea957`](https://github.com/nektos/act/commit/ddea9574fb0e2aa3877e704bc922190ba7062ade) refactor: split config merging into own function - [`b60da5a`](https://github.com/nektos/act/commit/b60da5a9a94c08f9e6e2b5b012ba0af826798908) Merge branch 'master' into add-networking-test ### 📊 Changes **3 files changed** (+63 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+48 -30) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/networking/push.yml` (+14 -0) </details> ### 📄 Description This test makes sure that the hostname inside of act is resolvable. This will prevent regressions in the network setup (see #1351, #1022) Act need to be started with docker network mode `host` by default. This was changed recently, leading to networking changes. That do break the previous (and expected) behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>