[PR #1351] [MERGED] fix: support docker create arguments from container.options (#1022) #1894

New issue

Closed

opened 2026-03-01 21:53:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1351
Author: @alex-savchuk
Created: 9/16/2022
Status: ✅ Merged
Merged: 10/6/2022
Merged by: @mergify[bot]

Base: master ← Head: support-docker-create-args

📝 Commits (7)

95dc69f fix: support docker create arguments from container.options (#1022)
6711e94 fix processing of errors, add verbose logging, fix test
9625c78 disable linter for code copied from docker/cli
fcd5a96 fix all linter issues
5d8ab29 Add license info
c7870dd Add opts_test.go from docker/cli and required testdata
0ea145d Merge branch 'master' into support-docker-create-args

📊 Changes

20 files changed (+2353 additions, -44 deletions)

View changed files

📝 .mega-linter.yml (+1 -1)
📝 IMAGES.md (+4 -4)
📝 README.md (+4 -4)
📝 go.mod (+11 -3)
📝 go.sum (+7 -1)
📝 pkg/common/git/git.go (+2 -1)
➕ pkg/container/DOCKER_LICENSE (+191 -0)
➕ pkg/container/docker_cli.go (+1083 -0)
➕ pkg/container/docker_cli_test.go (+982 -0)
📝 pkg/container/docker_run.go (+47 -5)
📝 pkg/container/file_collector.go (+1 -1)
➕ pkg/container/testdata/utf16.env (+0 -0)
➕ pkg/container/testdata/utf16be.env (+0 -0)
➕ pkg/container/testdata/utf8.env (+3 -0)
➕ pkg/container/testdata/valid.env (+1 -0)
➕ pkg/container/testdata/valid.label (+1 -0)
📝 pkg/exprparser/interpreter.go (+1 -1)
📝 pkg/model/planner.go (+2 -1)
📝 pkg/runner/run_context.go (+3 -19)
📝 pkg/runner/testdata/container-hostname/push.yml (+9 -3)

📄 Description

Important note: parsing of CLI options of docker is fetched from docker/cli sources explicitly - see docker_cli.go.
Please confirm it's acceptable.

Fixes https://github.com/nektos/act/issues/711
Fixes https://github.com/nektos/act/issues/1022

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1351 **Author:** [@alex-savchuk](https://github.com/alex-savchuk) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 10/6/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `support-docker-create-args` --- ### 📝 Commits (7) - [`95dc69f`](https://github.com/nektos/act/commit/95dc69f076e8ebea636a68d7cc6a3aabad5ad5aa) fix: support docker create arguments from container.options (#1022) - [`6711e94`](https://github.com/nektos/act/commit/6711e94efd1733edb6535486776df22d38e04c16) fix processing of errors, add verbose logging, fix test - [`9625c78`](https://github.com/nektos/act/commit/9625c78e4500f2e92899e2162b98faa3ea856ee2) disable linter for code copied from docker/cli - [`fcd5a96`](https://github.com/nektos/act/commit/fcd5a961ff4aeae47be4bf7a7d11d12e76120183) fix all linter issues - [`5d8ab29`](https://github.com/nektos/act/commit/5d8ab2946b258ba85bee1433025470fd69b1cfa6) Add license info - [`c7870dd`](https://github.com/nektos/act/commit/c7870ddffba5145a04b95707a1c99b2b7f0969ff) Add opts_test.go from docker/cli and required testdata - [`0ea145d`](https://github.com/nektos/act/commit/0ea145daf15d2106a388d5a137b1cb13a9b10939) Merge branch 'master' into support-docker-create-args ### 📊 Changes **20 files changed** (+2353 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `.mega-linter.yml` (+1 -1) 📝 `IMAGES.md` (+4 -4) 📝 `README.md` (+4 -4) 📝 `go.mod` (+11 -3) 📝 `go.sum` (+7 -1) 📝 `pkg/common/git/git.go` (+2 -1) ➕ `pkg/container/DOCKER_LICENSE` (+191 -0) ➕ `pkg/container/docker_cli.go` (+1083 -0) ➕ `pkg/container/docker_cli_test.go` (+982 -0) 📝 `pkg/container/docker_run.go` (+47 -5) 📝 `pkg/container/file_collector.go` (+1 -1) ➕ `pkg/container/testdata/utf16.env` (+0 -0) ➕ `pkg/container/testdata/utf16be.env` (+0 -0) ➕ `pkg/container/testdata/utf8.env` (+3 -0) ➕ `pkg/container/testdata/valid.env` (+1 -0) ➕ `pkg/container/testdata/valid.label` (+1 -0) 📝 `pkg/exprparser/interpreter.go` (+1 -1) 📝 `pkg/model/planner.go` (+2 -1) 📝 `pkg/runner/run_context.go` (+3 -19) 📝 `pkg/runner/testdata/container-hostname/push.yml` (+9 -3) </details> ### 📄 Description Important note: parsing of CLI options of docker is fetched from docker/cli sources explicitly - see docker_cli.go. Please confirm it's acceptable. Fixes https://github.com/nektos/act/issues/711 Fixes https://github.com/nektos/act/issues/1022 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:20 +03:00

[PR #1895] [MERGED] Remove archives.replacements in goreleaser.yaml #2179

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1894

No description provided.

Rows
Columns