[PR #1349] [MERGED] fix: missing defaults in nodejs pre #1893

New issue

Closed

opened 2026-03-01 21:53:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1349
Author: @ChristopherHX
Created: 9/15/2022
Status: ✅ Merged
Merged: 9/26/2022
Merged by: @mergify[bot]

Base: master ← Head: fix-missing-default-nodejs-pre

📝 Commits (3)

736a3d4 Update action.go
995a316 add Test
8f7935b Merge branch 'master' into fix-missing-default-nodejs-pre

📊 Changes

3 files changed (+26 additions, -0 deletions)

View changed files

📝 pkg/runner/action.go (+2 -0)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/remote-action-composite-js-pre-with-defaults/push.yml (+23 -0)

📄 Description

My action sets booleans to default value false, but these value was not provided by act in pre steps.
See action.yml github.com/ChristopherHX/script@d2555954ac/action.yml (L10)

Before this change this fails

[remote-action-composite-js-pre-with-defaults/test] ⭐ Run Pre nektos/act-test-actions/composite-js-pre-with-defaults/js@main
[remote-action-composite-js-pre-with-defaults/test]   🐳  docker cp src=C:\Users\User\.cache\act/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/ dst=/var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/
[remote-action-composite-js-pre-with-defaults/test]   🐳  docker exec cmd=[chown -R 1001:1001 /var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/] user=0 workdir=
[remote-action-composite-js-pre-with-defaults/test]   🐳  docker exec cmd=[node /var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/composite-js-pre-with-defaults/js/check.js] user= workdir=
| Unexpected input value pre: 'undefined' expected 'true' or 'false'
[remote-action-composite-js-pre-with-defaults/test]   💾  ::save-state name=FAILED::1
[remote-action-composite-js-pre-with-defaults/test]   ❌  Failure - Pre nektos/act-test-actions/composite-js-pre-with-defaults/js@main
[remote-action-composite-js-pre-with-defaults/test] 🏁  Job succeeded
Error: exitcode '1': failure

Add Test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1349 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 9/15/2022 **Status:** ✅ Merged **Merged:** 9/26/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-missing-default-nodejs-pre` --- ### 📝 Commits (3) - [`736a3d4`](https://github.com/nektos/act/commit/736a3d4ca6ded3f36823b5f3af78853d40c75efe) Update action.go - [`995a316`](https://github.com/nektos/act/commit/995a316e43658bc8731d7a90d5faefb06e914932) add Test - [`8f7935b`](https://github.com/nektos/act/commit/8f7935b8113db23eff937c2775381cb792031ad7) Merge branch 'master' into fix-missing-default-nodejs-pre ### 📊 Changes **3 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action.go` (+2 -0) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/remote-action-composite-js-pre-with-defaults/push.yml` (+23 -0) </details> ### 📄 Description My action sets booleans to default value false, but these value was not provided by act in pre steps. See action.yml https://github.com/ChristopherHX/script/blob/d2555954ac01dba5ed9a3f79dc11e97f9bfdf731/action.yml#L10 Before this change this fails ``` [remote-action-composite-js-pre-with-defaults/test] ⭐ Run Pre nektos/act-test-actions/composite-js-pre-with-defaults/js@main [remote-action-composite-js-pre-with-defaults/test] 🐳 docker cp src=C:\Users\User\.cache\act/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/ dst=/var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/ [remote-action-composite-js-pre-with-defaults/test] 🐳 docker exec cmd=[chown -R 1001:1001 /var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/] user=0 workdir= [remote-action-composite-js-pre-with-defaults/test] 🐳 docker exec cmd=[node /var/run/act/actions/nektos-act-test-actions-composite-js-pre-with-defaults-js@main/composite-js-pre-with-defaults/js/check.js] user= workdir= | Unexpected input value pre: 'undefined' expected 'true' or 'false' [remote-action-composite-js-pre-with-defaults/test] 💾 ::save-state name=FAILED::1 [remote-action-composite-js-pre-with-defaults/test] ❌ Failure - Pre nektos/act-test-actions/composite-js-pre-with-defaults/js@main [remote-action-composite-js-pre-with-defaults/test] 🏁 Job succeeded Error: exitcode '1': failure ``` - [x] Add Test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:20 +03:00

[PR #1893] [MERGED] build(deps): bump github.com/opencontainers/image-spec from 1.1.0-rc.3 to 1.1.0-rc4 #2178

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1893

No description provided.

Rows
Columns