[PR #1348] [MERGED] fix: crash on invalid docker credentials #1891

New issue

Closed

opened 2026-03-01 21:53:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1348
Author: @ChristopherHX
Created: 9/15/2022
Status: ✅ Merged
Merged: 9/26/2022
Merged by: @mergify[bot]

Base: master ← Head: fix-crash-invalid-credentials

📝 Commits (3)

0426a36 fix: crash on invalid docker credentials
01c2ddf add test
a3da3b5 Merge branch 'master' into fix-crash-invalid-credentials

📊 Changes

3 files changed (+16 additions, -4 deletions)

View changed files

📝 pkg/runner/job_executor.go (+2 -4)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/job-container-invalid-credentials/push.yml (+13 -0)

📄 Description

We cannot run post steps, if we have no job container.
This change skips post steps, if startContainer() fails.

Before this change see referenced issue
After this change:

Error: failed to handle credentials: failed to interpolate container.credentials.password

Add Test

Fixes #1306

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1348 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 9/15/2022 **Status:** ✅ Merged **Merged:** 9/26/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-crash-invalid-credentials` --- ### 📝 Commits (3) - [`0426a36`](https://github.com/nektos/act/commit/0426a3623bf058ef40d4872bd98e98fb6dd4ce4c) fix: crash on invalid docker credentials - [`01c2ddf`](https://github.com/nektos/act/commit/01c2ddf123dab17e3d2ca207631b788221e19490) add test - [`a3da3b5`](https://github.com/nektos/act/commit/a3da3b546ea70e5cd1e86ce7a6ae1f5ab3fc3124) Merge branch 'master' into fix-crash-invalid-credentials ### 📊 Changes **3 files changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+2 -4) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/job-container-invalid-credentials/push.yml` (+13 -0) </details> ### 📄 Description We cannot run post steps, if we have no job container. This change skips post steps, if startContainer() fails. Before this change see referenced issue After this change: ``` Error: failed to handle credentials: failed to interpolate container.credentials.password ``` - [x] Add Test Fixes #1306 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1891

No description provided.

Rows
Columns