[PR #1282] [MERGED] walk submodule path instead of dir name #1875

Closed
opened 2026-03-01 21:53:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1282
Author: @ermalkaleci
Created: 7/27/2022
Status: Merged
Merged: 7/28/2022
Merged by: @mergify[bot]

Base: masterHead: fix-submodule-walk


📝 Commits (3)

  • 154fa21 walk submodule path instead of dir name
  • 98155da use file path instead of relative path
  • 04b6a22 Merge branch 'master' into fix-submodule-walk

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/container/file_collector.go (+1 -1)

📄 Description

Having submodule located into a different path than submodule name will make walk file to fail.

[submodule "stable-asset"]
	path = ecosystem-modules/stable-asset
	url = https://github.com/nutsfinance/stable-asset.git

It will walk stable-asset and failing with lstat stable-asset: no such file or directory
This PR will change it and walk the path instead


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1282 **Author:** [@ermalkaleci](https://github.com/ermalkaleci) **Created:** 7/27/2022 **Status:** ✅ Merged **Merged:** 7/28/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-submodule-walk` --- ### 📝 Commits (3) - [`154fa21`](https://github.com/nektos/act/commit/154fa214a484eadcfc359f81aecb81306b9bd5c2) walk submodule path instead of dir name - [`98155da`](https://github.com/nektos/act/commit/98155da1136443fc2d973eddcc4ed8ccffcbadf9) use file path instead of relative path - [`04b6a22`](https://github.com/nektos/act/commit/04b6a22f28a324d24b5758a491d0d38bf1439ee2) Merge branch 'master' into fix-submodule-walk ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/file_collector.go` (+1 -1) </details> ### 📄 Description Having submodule located into a different path than submodule name will make walk file to fail. ``` [submodule "stable-asset"] path = ecosystem-modules/stable-asset url = https://github.com/nutsfinance/stable-asset.git ``` It will walk `stable-asset` and failing with `lstat stable-asset: no such file or directory` This PR will change it and walk the path instead --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1875
No description provided.